Set up a few fields necessarily to make Chrome OS boot without showing a
firmware error.

Signed-off-by: Simon Glass <s...@chromium.org>
Reviewed-by: Bin Meng <bmeng...@gmail.com>
---

(no changes since v1)

 arch/x86/cpu/apollolake/acpi.c | 26 ++++++++++++++++++++------
 1 file changed, 20 insertions(+), 6 deletions(-)

diff --git a/arch/x86/cpu/apollolake/acpi.c b/arch/x86/cpu/apollolake/acpi.c
index 5af8a181b1e..fd21c0b4968 100644
--- a/arch/x86/cpu/apollolake/acpi.c
+++ b/arch/x86/cpu/apollolake/acpi.c
@@ -65,6 +65,21 @@ int arch_write_sci_irq_select(uint scis)
        return 0;
 }
 
+/**
+ * chromeos_init_acpi() - Initialise basic data to boot Chrome OS
+ *
+ * This tells Chrome OS to boot in developer mode
+ *
+ * @cros: Structure to initialise
+ */
+static void chromeos_init_acpi(struct chromeos_acpi_gnvs *cros)
+{
+       cros->active_main_fw = 1;
+       cros->active_main_fw = 1; /* A */
+       cros->switches = CHSW_DEVELOPER_SWITCH;
+       cros->main_fw_type = 2; /* Developer */
+}
+
 int acpi_create_gnvs(struct acpi_global_nvs *gnvs)
 {
        struct udevice *cpu;
@@ -75,12 +90,9 @@ int acpi_create_gnvs(struct acpi_global_nvs *gnvs)
 
        /* TODO(s...@chromium.org): Add the console log to gnvs->cbmc */
 
-/* Disable this code until a later patch */
-#if 0
-       /* Initialise Verified Boot data */
-       chromeos_init_acpi(&gnvs->chromeos);
-       gnvs->chromeos.vbt2 = ACTIVE_ECFW_RO;
-#endif
+       if (IS_ENABLED(CONFIG_CHROMEOS))
+               chromeos_init_acpi(&gnvs->chromeos);
+
        /* Set unknown wake source */
        gnvs->pm1i = ~0ULL;
 
@@ -93,6 +105,8 @@ int acpi_create_gnvs(struct acpi_global_nvs *gnvs)
                        gnvs->pcnt = ret;
        }
 
+       gnvs->dpte = 1;
+
        return 0;
 }
 
-- 
2.29.1.341.ge80a0c044ae-goog

Reply via email to