Re: [PATCH v3 3/4] spi-nor: Adapt soft reset to XTX25F32B in Rock Pi 4 rev 1.4

2022-09-01 Thread Kever Yang
Hi Jagan,     This patchset goes into my todo list, but I'm not very good at SPI module, how do you think about this patchset?     I will happy to merge this if there is no regression for other SPI NOR device. Thanks,  - Kever On 2022/7/20 23:42, Xavier Drudis Ferran wrote: XTX25F32B do

Re: [SPAM] Re: [PATCH v3 3/4] spi-nor: Adapt soft reset to XTX25F32B in Rock Pi 4 rev 1.4

2022-07-26 Thread Xavier Drudis Ferran
El Tue, Jul 26, 2022 at 02:39:09PM +0530, Pratyush Yadav deia: > > Yes, this is indeed a chicken and egg problem of sorts. The octal mode > soft reset I added is a hack that gets _some_ flashes working but not > all. I see 3 possible ways to solve this: > But it was a hack that solved a proble

Re: [PATCH v3 3/4] spi-nor: Adapt soft reset to XTX25F32B in Rock Pi 4 rev 1.4

2022-07-26 Thread Pratyush Yadav
On 26/07/22 10:27AM, Xavier Drudis Ferran wrote: > > Thank you for your time looking at the patch. > > El Tue, Jul 26, 2022 at 12:43:06PM +0530, Pratyush Yadav deia: > > > > Please don't put the changelog in the commit message. Put it below the 3 > > dashed lines below. > > > > Sorry. Will tr

Re: [PATCH v3 3/4] spi-nor: Adapt soft reset to XTX25F32B in Rock Pi 4 rev 1.4

2022-07-26 Thread Xavier Drudis Ferran
Thank you for your time looking at the patch. El Tue, Jul 26, 2022 at 12:43:06PM +0530, Pratyush Yadav deia: > > Please don't put the changelog in the commit message. Put it below the 3 > dashed lines below. > Sorry. Will try to remember it next time. Not sure there's a next version of this

Re: [PATCH v3 3/4] spi-nor: Adapt soft reset to XTX25F32B in Rock Pi 4 rev 1.4

2022-07-26 Thread Pratyush Yadav
On 20/07/22 05:42PM, Xavier Drudis Ferran wrote: > XTX25F32B does not use octal mode and accepts soft reset, despite its > SFDP tables. Soft reset at U-Boot exit seems to be required to write > to /dev/mtd0 from flashrom in linux. Soft reset at U-Boot start seems > to help booting from SPI (at leas

[PATCH v3 3/4] spi-nor: Adapt soft reset to XTX25F32B in Rock Pi 4 rev 1.4

2022-07-20 Thread Xavier Drudis Ferran
XTX25F32B does not use octal mode and accepts soft reset, despite its SFDP tables. Soft reset at U-Boot exit seems to be required to write to /dev/mtd0 from flashrom in linux. Soft reset at U-Boot start seems to help booting from SPI (at least with the dts properties I'm using). The first soft res