Re: [PATCH v4 07/11] bootmenu: add UEFI and disto_boot entries

2022-04-04 Thread Masahisa Kojima
On Sat, 2 Apr 2022 at 15:33, Heinrich Schuchardt wrote: > > On 3/24/22 14:54, Masahisa Kojima wrote: > > This commit adds the UEFI related menu entries and > > distro_boot entries into the bootmenu. > > > > For UEFI, user can select which UEFI "Boot" option > > to execute, call UEFI bootmgr an

Re: [PATCH v4 07/11] bootmenu: add UEFI and disto_boot entries

2022-04-01 Thread Heinrich Schuchardt
On 3/24/22 14:54, Masahisa Kojima wrote: This commit adds the UEFI related menu entries and distro_boot entries into the bootmenu. For UEFI, user can select which UEFI "Boot" option to execute, call UEFI bootmgr and UEFI boot variable maintenance menu. UEFI bootmgr entry is required to corre

Re: [PATCH v4 07/11] bootmenu: add UEFI and disto_boot entries

2022-03-31 Thread Ilias Apalodimas
Hi Kojima-san, [...] > + entry->title = u16_strdup(lo.label); > + if (!entry->title) { > + free(load_option); > + free(entry); We need to free bootorder as well > + return

[PATCH v4 07/11] bootmenu: add UEFI and disto_boot entries

2022-03-24 Thread Masahisa Kojima
This commit adds the UEFI related menu entries and distro_boot entries into the bootmenu. For UEFI, user can select which UEFI "Boot" option to execute, call UEFI bootmgr and UEFI boot variable maintenance menu. UEFI bootmgr entry is required to correctly handle "BootNext" variable. For distr