RE: [PATCH v4 1/2] net: brcm: netXtreme driver

2021-11-01 Thread Roman Bacik
Hi Marek, > -Original Message- > From: Marek Behún > Sent: Sunday, October 31, 2021 3:56 AM > To: Roman Bacik > Cc: U-Boot Mailing List ; Bharat Gooty > ; Joe Hershberger > ; Ramon Fried ; > p...@kernel.org > Subject: Re: [PATCH v4 1/2] net: brcm: netXtrem

Re: [PATCH v4 1/2] net: brcm: netXtreme driver

2021-10-31 Thread Marek Behún
On Sat, 30 Oct 2021 08:48:05 -0700 Roman Bacik wrote: > The mac address can be read from bp only after bnxt_bring_chip is > called, which is after read_rom_hwaddr is called. Theoretically we can > call bnxt_bring_chip in bind or in read_rom_hwaddr and then one can > use this method if desired. H

Re: [PATCH v4 1/2] net: brcm: netXtreme driver

2021-10-30 Thread Roman Bacik
Hi Marek, On Sat, Oct 30, 2021 at 8:00 AM Marek Behún wrote: > > Hello Roman, > > On Thu, 28 Oct 2021 16:29:28 -0700 > Roman Bacik wrote: > > > +void bnxt_env_set_ethaddr(struct udevice *dev) > > +{ > > + struct eth_pdata *plat = dev_get_plat(dev); > > + char cmd[100]; > > + char var

Re: [PATCH v4 1/2] net: brcm: netXtreme driver

2021-10-30 Thread Marek Behún
Hello Roman, On Thu, 28 Oct 2021 16:29:28 -0700 Roman Bacik wrote: > +void bnxt_env_set_ethaddr(struct udevice *dev) > +{ > + struct eth_pdata *plat = dev_get_plat(dev); > + char cmd[100]; > + char var[32]; > + u8 mac_env[ARP_HLEN]; > + > + eth_env_get_enetaddr_by_index("eth"

[PATCH v4 1/2] net: brcm: netXtreme driver

2021-10-28 Thread Roman Bacik
From: Bharat Gooty Broadcom bnxt L2 driver support. Used by the Broadcom iproc platforms. Signed-off-by: Bharat Gooty Reviewed-by: Ramon Fried Signed-off-by: Roman Bacik --- Changes in v4: - remove static num_cards and use dev_seq(dev) instead - add .probe - merged probe/remove methods - se