Re: [PATCH v4 2/2] android_ab: Fix ANDROID_AB_BACKUP_OFFSET

2024-03-21 Thread Colin
Hi Mattijs, Sorry, I did not realize there were outstanding issues for me to address. I would be happy to send a v5, but if you doing the fixups gets this merged quicker, that sounds better to me. Happy to contribute, *_* *Colin McAllister* On Thu, Mar 21, 2024 at 4:29 AM

Re: [PATCH v4 2/2] android_ab: Fix ANDROID_AB_BACKUP_OFFSET

2024-03-21 Thread Mattijs Korpershoek
Hi Colin, Since both below remarks are minor nitpicks, I can also do them when applying (to avoid delaying this series too much). Please le me know what you prefer: 1. You send a v5 at your convience 2. I do the minor fixups and I merge right away. Again, thank you for doing your first U-Boot

Re: [PATCH v4 2/2] android_ab: Fix ANDROID_AB_BACKUP_OFFSET

2024-03-13 Thread Igor Opaniuk
Hi Colin, On Tue, Mar 12, 2024 at 4:19 PM Mattijs Korpershoek < mkorpersh...@baylibre.com> wrote: > Hi Colin, > > Thank you for the patch. > > On mar., mars 12, 2024 at 07:57, Colin McAllister > wrote: > > Sam also gave his review here: > >

Re: [PATCH v4 2/2] android_ab: Fix ANDROID_AB_BACKUP_OFFSET

2024-03-12 Thread Mattijs Korpershoek
Hi Colin, Thank you for the patch. On mar., mars 12, 2024 at 07:57, Colin McAllister wrote: Sam also gave his review here: https://lore.kernel.org/all/CAPLW+4kHmPtfACyND4Vc2p0ZrsyGY=+bRU=fdub4k1ux5p3...@mail.gmail.com/ Please include his review tag in the next submission. I will add it at

[PATCH v4 2/2] android_ab: Fix ANDROID_AB_BACKUP_OFFSET

2024-03-12 Thread Colin McAllister
From: Colin McAllister Currently, setting CONFIG_AB_BACKUP_OFFSET in a target's defconfig will not actually enable the #if protected code in android_ab.c. This is because "CONFIG_" should have been prepended to the config macro, or the macros defined in kconfig.h could have been used. The code