Re: [PATCH v4 3/4] i2c: stm32: do not set the STOP condition on error

2022-09-15 Thread Patrick DELAUNAY
Hi Alain, On 9/12/22 10:42, Alain Volmat wrote: Current function stm32_i2c_message_xfer is sending a STOP whatever the result of the transaction is. This can cause issues such as making the bus busy since the controller itself is already sending automatically a STOP when a NACK is generated. T

Re: [PATCH v4 3/4] i2c: stm32: do not set the STOP condition on error

2022-09-15 Thread Patrick DELAUNAY
Hi Alain On 9/12/22 10:42, Alain Volmat wrote: Current function stm32_i2c_message_xfer is sending a STOP whatever the result of the transaction is. This can cause issues such as making the bus busy since the controller itself is already sending automatically a STOP when a NACK is generated. Th

[PATCH v4 3/4] i2c: stm32: do not set the STOP condition on error

2022-09-12 Thread Alain Volmat
Current function stm32_i2c_message_xfer is sending a STOP whatever the result of the transaction is. This can cause issues such as making the bus busy since the controller itself is already sending automatically a STOP when a NACK is generated. Thanks to Jorge Ramirez-Ortiz for diagnosing and pro

Re: [PATCH v4 3/4] i2c: stm32: do not set the STOP condition on error

2022-09-12 Thread Patrick DELAUNAY
Hi, On 9/12/22 10:42, Alain Volmat wrote: Current function stm32_i2c_message_xfer is sending a STOP whatever the result of the transaction is. This can cause issues such as making the bus busy since the controller itself is already sending automatically a STOP when a NACK is generated. Thanks

Re: [PATCH v4 3/4] i2c: stm32: do not set the STOP condition on error

2022-09-12 Thread Heiko Schocher
Hello Alain, On 12.09.22 10:42, Alain Volmat wrote: > Current function stm32_i2c_message_xfer is sending a STOP > whatever the result of the transaction is. This can cause issues > such as making the bus busy since the controller itself is already > sending automatically a STOP when a NACK is gen

Re: [PATCH v4 3/4] i2c: stm32: do not set the STOP condition on error

2022-09-12 Thread Patrice CHOTARD
On 9/12/22 10:42, Alain Volmat wrote: > Current function stm32_i2c_message_xfer is sending a STOP > whatever the result of the transaction is. This can cause issues > such as making the bus busy since the controller itself is already > sending automatically a STOP when a NACK is generated. > >