Re: [PATCH v5 04/15] bootstd: Fix listing boot devices

2022-10-02 Thread Michal Suchánek
On Thu, Sep 29, 2022 at 04:00:32AM -0600, Simon Glass wrote: > Hi Michal, > > On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote: > > > > bootdev_list() uses uclass_*_device_err() to iterate devices. > > However, the only value _err adds is returning an error when the device > > pointer is null

Re: [PATCH v5 04/15] bootstd: Fix listing boot devices

2022-09-29 Thread Simon Glass
Hi Michal, On Tue, 27 Sept 2022 at 15:38, Michal Suchanek wrote: > > bootdev_list() uses uclass_*_device_err() to iterate devices. > However, the only value _err adds is returning an error when the device > pointer is null, and that's checked anyway. > > Also there is some intent to report errors

[PATCH v5 04/15] bootstd: Fix listing boot devices

2022-09-27 Thread Michal Suchanek
bootdev_list() uses uclass_*_device_err() to iterate devices. However, the only value _err adds is returning an error when the device pointer is null, and that's checked anyway. Also there is some intent to report errors, and that's what uclass_*_device_check() is for, use it. Also print the symb