Re: [PATCH v5 10/29] pci: Adjust dm_pci_read_bar32() to return errors correctly

Hi, On Thu, 9 Apr 2020 at 03:39, Mark Kettenis wrote: > > > From: Andy Shevchenko > > Date: Thu, 9 Apr 2020 12:06:11 +0300 > > > > On Thu, Apr 9, 2020 at 2:00 AM Simon Glass wrote: > > > > > > At present if reading a BAR returns 0x (e.g. the device is not > > > present) then the value

Re: [PATCH v5 10/29] pci: Adjust dm_pci_read_bar32() to return errors correctly

> From: Andy Shevchenko > Date: Thu, 9 Apr 2020 12:06:11 +0300 > > On Thu, Apr 9, 2020 at 2:00 AM Simon Glass wrote: > > > > At present if reading a BAR returns 0x (e.g. the device is not > > present) then the value is masked and a different value is returned. > > This makes it harder

Re: [PATCH v5 10/29] pci: Adjust dm_pci_read_bar32() to return errors correctly

On Thu, Apr 9, 2020 at 2:00 AM Simon Glass wrote: > > At present if reading a BAR returns 0x (e.g. the device is not > present) then the value is masked and a different value is returned. > This makes it harder to detect the problem when debugging. If you insisting on the code, you may

[PATCH v5 10/29] pci: Adjust dm_pci_read_bar32() to return errors correctly

At present if reading a BAR returns 0x (e.g. the device is not present) then the value is masked and a different value is returned. This makes it harder to detect the problem when debugging. Update the function to avoid masking in this case. Signed-off-by: Simon Glass Reviewed-by: Bin