[PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file

2021-10-01 Thread Simon Glass
At present U-Boot environment variables, and thus scripts, are defined by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text to this file and dealing with quoting and newlines is harder than it should be. It would be better if we could just type the script into a text file and ha

Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file

2021-10-05 Thread Simon Glass
Hi Wolfgang, On Mon, 4 Oct 2021 at 06:08, Wolfgang Denk wrote: > > Dear Simon, > > In message > <20211001183842.v5.3.If789ba3e2667c46c03eda3386ca84a863baeda55@changeid> you > wrote: > > > > Add a feature that brings in a .env file associated with the board > > config, if present. To use it, cre

Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file

2021-10-05 Thread Simon Glass
Hi Rasmus, On Mon, 4 Oct 2021 at 01:28, Rasmus Villemoes wrote: > > On 02/10/2021 02.38, Simon Glass wrote: > > At present U-Boot environment variables, and thus scripts, are defined > > by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text > > to this file and dealing with quo

Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file

2021-10-05 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > > Add a feature that brings in a .env file associated with the board > > > config, if present. To use it, create a file in a board//env > > > directory called .env (or common.env if you want the same > > > environment for all boards). > > > > This should b

Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file

2021-10-05 Thread Simon Glass
Hi Wolfgang, On Tue, 5 Oct 2021 at 08:56, Wolfgang Denk wrote: > > Dear Simon, > > In message > you > wrote: > > > > > > Add a feature that brings in a .env file associated with the board > > > > config, if present. To use it, create a file in a board//env > > > > directory called .env (or com

Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file

2021-10-05 Thread Tom Rini
On Tue, Oct 05, 2021 at 09:33:18AM -0600, Simon Glass wrote: > Hi Wolfgang, > > On Tue, 5 Oct 2021 at 08:56, Wolfgang Denk wrote: > > > > Dear Simon, > > > > In message > > you > > wrote: > > > > > > > > Add a feature that brings in a .env file associated with the board > > > > > config, if pr

Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file

2021-10-05 Thread Simon Glass
Hi Tom, On Tue, 5 Oct 2021 at 09:52, Tom Rini wrote: > > On Tue, Oct 05, 2021 at 09:33:18AM -0600, Simon Glass wrote: > > Hi Wolfgang, > > > > On Tue, 5 Oct 2021 at 08:56, Wolfgang Denk wrote: > > > > > > Dear Simon, > > > > > > In message > > > you > > > wrote: > > > > > > > > > > Add a feat

Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file

2021-10-06 Thread Wolfgang Denk
Dear Simon, In message you wrote: > > > 1) This requires that the .env files are run through CPP, which is > >only added in a later patch. > > OK perhaps I should just merge the patches. It is a bit artificial > having two and it seems that people agree we need the += syntax. Yes, some way

Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file

2021-10-04 Thread Rasmus Villemoes
On 02/10/2021 02.38, Simon Glass wrote: > At present U-Boot environment variables, and thus scripts, are defined > by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text > to this file and dealing with quoting and newlines is harder than it > should be. It would be better if we co

Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file

2021-10-04 Thread Wolfgang Denk
Dear Simon, In message <20211001183842.v5.3.If789ba3e2667c46c03eda3386ca84a863baeda55@changeid> you wrote: > > Add a feature that brings in a .env file associated with the board > config, if present. To use it, create a file in a board//env > directory called .env (or common.env if you want the

Re: [PATCH v5 3/5] env: Allow U-Boot scripts to be placed in a .env file

2021-10-04 Thread Tom Rini
On Mon, Oct 04, 2021 at 09:28:43AM +0200, Rasmus Villemoes wrote: > On 02/10/2021 02.38, Simon Glass wrote: > > At present U-Boot environment variables, and thus scripts, are defined > > by CONFIG_EXTRA_ENV_SETTINGS. It is painful to add large amounts of text > > to this file and dealing with quot