Re: [PATCH v6 14/37] efi_loader: Allocate and write ACPI tables

2024-10-03 Thread Simon Glass
Hi Ilias, On Thu, 3 Oct 2024 at 09:59, Ilias Apalodimas wrote: > > Hi Simon, > > On Thu, 3 Oct 2024 at 16:49, Simon Glass wrote: > > > > Hi Ilias, > > > > On Wed, 2 Oct 2024 at 23:45, Ilias Apalodimas > > wrote: > > > > > > Hi Patrick, > > > > > > We've been back and forth on this, but we still

Re: [PATCH v6 14/37] efi_loader: Allocate and write ACPI tables

2024-10-03 Thread Ilias Apalodimas
Hi Simon, On Thu, 3 Oct 2024 at 16:49, Simon Glass wrote: > > Hi Ilias, > > On Wed, 2 Oct 2024 at 23:45, Ilias Apalodimas > wrote: > > > > Hi Patrick, > > > > We've been back and forth on this, but we still disagree on the > > allocations etc, but I don't think it's that important to keep the >

Re: [PATCH v6 14/37] efi_loader: Allocate and write ACPI tables

2024-10-03 Thread Simon Glass
Hi Ilias, On Wed, 2 Oct 2024 at 23:45, Ilias Apalodimas wrote: > > Hi Patrick, > > We've been back and forth on this, but we still disagree on the > allocations etc, but I don't think it's that important to keep the > patch out due to this. > > Can we move the table generation to the ACPI subsyst

Re: [PATCH v6 14/37] efi_loader: Allocate and write ACPI tables

2024-10-02 Thread Ilias Apalodimas
Hi Patrick, We've been back and forth on this, but we still disagree on the allocations etc, but I don't think it's that important to keep the patch out due to this. Can we move the table generation to the ACPI subsystem? efi_acpi_register() will convert the memory as needed, so I was wondering w

Re: [PATCH v6 14/37] efi_loader: Allocate and write ACPI tables

2024-10-02 Thread Simon Glass
Hi Patrick, On Wed, 2 Oct 2024 at 03:52, Patrick Rudolph wrote: > > Allocate memory for ACPI tables inside the efi_loader and write out > the tables similar to SMBIOS tables. When ACPI is enabled and wasn't > installed in other places, install the ACPI table in EFI. Since EFI > is necessary to pa

[PATCH v6 14/37] efi_loader: Allocate and write ACPI tables

2024-10-02 Thread Patrick Rudolph
Allocate memory for ACPI tables inside the efi_loader and write out the tables similar to SMBIOS tables. When ACPI is enabled and wasn't installed in other places, install the ACPI table in EFI. Since EFI is necessary to pass the ACPI table location when FDT isn't used, there's no need to install i