Re: [PATCHv2 2/2] i2c: stm32f7: do not set the STOP condition on error

2022-09-09 Thread Patrick DELAUNAY
Hi, On 9/7/22 11:20, Alain Volmat wrote: Hi, I confirm that a fix is necessary regarding this setting of the stop condition. As a matter of fact, the controller is already sending the stop condition in case of NACK so there is no need to send the stop condition. However, this fix is not

Re: [PATCHv2 2/2] i2c: stm32f7: do not set the STOP condition on error

2022-09-07 Thread Alain Volmat
Hi, I confirm that a fix is necessary regarding this setting of the stop condition. As a matter of fact, the controller is already sending the stop condition in case of NACK so there is no need to send the stop condition. However, this fix is not enough since the nack could be detected few lines

Re: [PATCHv2 2/2] i2c: stm32f7: do not set the STOP condition on error

2022-08-25 Thread Patrice CHOTARD
+Alain (with the correct email address ;-)) Alain, can you have a look a this patch and give your feedback on it. On my side i tested it on stm32mp157c-ev1 and stm32mp157c-dk2, i didn't see any regression but i prefer to get expert feedback Thanks Patrice On 8/15/22 16:52, Jorge

Re: [PATCHv2 2/2] i2c: stm32f7: do not set the STOP condition on error

2022-08-25 Thread Patrice CHOTARD
+Alain Alain, can you have a look a this patch and give your feedback on it. On my side i tested it on stm32mp157c-ev1 and stm32mp157c-dk2, i didn't see any regression but i prefer to get expert feedback ;-) Thanks Patrice On 8/15/22 16:52, Jorge Ramirez-Ortiz wrote: > Sending the stop

[PATCHv2 2/2] i2c: stm32f7: do not set the STOP condition on error

2022-08-15 Thread Jorge Ramirez-Ortiz
Sending the stop condition without waiting for transfer complete has been found to lock the bus (BUSY) when NACKF is raised. Tested accessing the NXP SE05X I2C device. https://www.nxp.com/docs/en/application-note/AN12399.pdf Signed-off-by: Jorge Ramirez-Ortiz Reviewed-by: Oleksandr Suvorov ---