Re: [RESEND RFC PATCH 03/10] FWU: Add metadata structure and functions for accessing metadata

2021-12-01 Thread Sughosh Ganu
hi Ilias, On Wed, 1 Dec 2021 at 13:20, Ilias Apalodimas wrote: > Hi Sughosh, > > [...] > >> > +{ > >> > + struct fwu_metadata_ops *ops; > >> > >> The metadata is an untrusted information source and hence MUST NOT be > >> used to map the image_type_id to the DFU alt_number. Don't invite for a

Re: [RESEND RFC PATCH 03/10] FWU: Add metadata structure and functions for accessing metadata

2021-11-30 Thread Ilias Apalodimas
Hi Sughosh, [...] >> > +{ >> > + struct fwu_metadata_ops *ops; >> >> The metadata is an untrusted information source and hence MUST NOT be >> used to map the image_type_id to the DFU alt_number. Don't invite for an >> denial of service attack. >> >> The signed capsule would be a good place for

Re: [RESEND RFC PATCH 03/10] FWU: Add metadata structure and functions for accessing metadata

2021-11-30 Thread Ilias Apalodimas
Hi Heinrich, [...] > > +/** > > + * fwu_get_image_alt_num() - Get the dfu alt number to be used for capsule > > update > > + * @image_type_id: image guid as passed in the capsule > > + * @update_bank: Bank to which the update is to be made > > + * @alt_num: The alt_num for the image > > + * > >

Re: [RESEND RFC PATCH 03/10] FWU: Add metadata structure and functions for accessing metadata

2021-11-30 Thread Sughosh Ganu
hi Simon, On Wed, 1 Dec 2021 at 11:56, Simon Glass wrote: > Hi, > > On Thu, 25 Nov 2021 at 00:13, Sughosh Ganu > wrote: > > > > In the FWU Multi Bank Update feature, the information about the > > updatable images is stored as part of the metadata, which is stored on > > a dedicated partition. A

Re: [RESEND RFC PATCH 03/10] FWU: Add metadata structure and functions for accessing metadata

2021-11-30 Thread Simon Glass
Hi, On Thu, 25 Nov 2021 at 00:13, Sughosh Ganu wrote: > > In the FWU Multi Bank Update feature, the information about the > updatable images is stored as part of the metadata, which is stored on > a dedicated partition. Add the metadata structure, and functions to > access the metadata. These are

Re: [RESEND RFC PATCH 03/10] FWU: Add metadata structure and functions for accessing metadata

2021-11-30 Thread Sughosh Ganu
On Tue, 30 Nov 2021 at 18:33, Heinrich Schuchardt wrote: > On 11/25/21 08:12, Sughosh Ganu wrote: > > In the FWU Multi Bank Update feature, the information about the > > updatable images is stored as part of the metadata, which is stored on > > a dedicated partition. Add the metadata structure, a

Re: [RESEND RFC PATCH 03/10] FWU: Add metadata structure and functions for accessing metadata

2021-11-30 Thread Heinrich Schuchardt
On 11/25/21 08:12, Sughosh Ganu wrote: In the FWU Multi Bank Update feature, the information about the updatable images is stored as part of the metadata, which is stored on a dedicated partition. Add the metadata structure, and functions to access the metadata. These are generic API's, and imple

Re: [RESEND RFC PATCH 03/10] FWU: Add metadata structure and functions for accessing metadata

2021-11-28 Thread Sughosh Ganu
hi Ilias, Thanks for the review. On Fri, 26 Nov 2021 at 17:05, Ilias Apalodimas wrote: > Hi Sughosh, > > On Thu, Nov 25, 2021 at 12:42:55PM +0530, Sughosh Ganu wrote: > > In the FWU Multi Bank Update feature, the information about the > > updatable images is stored as part of the metadata, which

Re: [RESEND RFC PATCH 03/10] FWU: Add metadata structure and functions for accessing metadata

2021-11-26 Thread Ilias Apalodimas
Hi Sughosh, On Thu, Nov 25, 2021 at 12:42:55PM +0530, Sughosh Ganu wrote: > In the FWU Multi Bank Update feature, the information about the > updatable images is stored as part of the metadata, which is stored on > a dedicated partition. Add the metadata structure, and functions to > access the m

[RESEND RFC PATCH 03/10] FWU: Add metadata structure and functions for accessing metadata

2021-11-24 Thread Sughosh Ganu
In the FWU Multi Bank Update feature, the information about the updatable images is stored as part of the metadata, which is stored on a dedicated partition. Add the metadata structure, and functions to access the metadata. These are generic API's, and implementations can be added based on paramete