Re: [RFC][PATCH] spl: Turn spl_board_init() into weak symbol

2022-09-22 Thread Marek Vasut
On 9/22/22 13:27, Simon Glass wrote: Hi, [...] It's similar, yes. I think the biggest hang-up for me is that while the Kconfig help text isn't the best documentation for what is needed when adding SPL to a board, it's better than code-only comments. I know Simon asked for a comment on the weak

Re: [RFC][PATCH] spl: Turn spl_board_init() into weak symbol

2022-09-22 Thread Simon Glass
Hi Tom, On Wed, 21 Sept 2022 at 15:49, Tom Rini wrote: > > On Wed, Sep 21, 2022 at 02:56:29AM +0200, Marek Vasut wrote: > > On 9/20/22 21:04, Tom Rini wrote: > > > On Tue, Sep 20, 2022 at 05:56:50PM +0200, Marek Vasut wrote: > > > > On 9/20/22 17:43, Simon Glass wrote: > > > > > On Mon, 19 Sept 2

Re: [RFC][PATCH] spl: Turn spl_board_init() into weak symbol

2022-09-21 Thread Tom Rini
On Wed, Sep 21, 2022 at 02:56:29AM +0200, Marek Vasut wrote: > On 9/20/22 21:04, Tom Rini wrote: > > On Tue, Sep 20, 2022 at 05:56:50PM +0200, Marek Vasut wrote: > > > On 9/20/22 17:43, Simon Glass wrote: > > > > On Mon, 19 Sept 2022 at 21:52, Marek Vasut wrote: > > > > > > > > > > Make spl_board

Re: [RFC][PATCH] spl: Turn spl_board_init() into weak symbol

2022-09-20 Thread Marek Vasut
On 9/20/22 21:04, Tom Rini wrote: On Tue, Sep 20, 2022 at 05:56:50PM +0200, Marek Vasut wrote: On 9/20/22 17:43, Simon Glass wrote: On Mon, 19 Sept 2022 at 21:52, Marek Vasut wrote: Make spl_board_init() a weak symbol and get rid of Kconfig symbols and ifdeffery guarding this function. Since

Re: [RFC][PATCH] spl: Turn spl_board_init() into weak symbol

2022-09-20 Thread Tom Rini
On Tue, Sep 20, 2022 at 05:56:50PM +0200, Marek Vasut wrote: > On 9/20/22 17:43, Simon Glass wrote: > > On Mon, 19 Sept 2022 at 21:52, Marek Vasut wrote: > > > > > > Make spl_board_init() a weak symbol and get rid of Kconfig symbols > > > and ifdeffery guarding this function. Since the spl_board_

Re: [RFC][PATCH] spl: Turn spl_board_init() into weak symbol

2022-09-20 Thread Marek Vasut
On 9/20/22 17:43, Simon Glass wrote: On Mon, 19 Sept 2022 at 21:52, Marek Vasut wrote: Make spl_board_init() a weak symbol and get rid of Kconfig symbols and ifdeffery guarding this function. Since the spl_board_init() is now a weak symbol, boards can either use the default implementation whic

Re: [RFC][PATCH] spl: Turn spl_board_init() into weak symbol

2022-09-20 Thread Simon Glass
On Mon, 19 Sept 2022 at 21:52, Marek Vasut wrote: > > Make spl_board_init() a weak symbol and get rid of Kconfig symbols > and ifdeffery guarding this function. Since the spl_board_init() is > now a weak symbol, boards can either use the default implementation > which is empty and gets inlined wit

[RFC][PATCH] spl: Turn spl_board_init() into weak symbol

2022-09-19 Thread Marek Vasut
Make spl_board_init() a weak symbol and get rid of Kconfig symbols and ifdeffery guarding this function. Since the spl_board_init() is now a weak symbol, boards can either use the default implementation which is empty and gets inlined with zero text increase, or override the implementation with the