Re: [RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-12-01 Thread Matwey V. Kornilov
вт, 29 нояб. 2022 г. в 09:50, Neha Malcom Francis : > > EEPROM detection logic in ti_i2c_eeprom_get() involves figuring out > whether addressing is 1-byte or 2-byte. There are currently different > behaviours seen across boards as documented in commit bf6376642fe8 > ("board: ti: common:

Re: [RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-11-30 Thread Tom Rini
On Wed, Nov 30, 2022 at 06:38:43PM +0300, Matwey V. Kornilov wrote: > ср, 30 нояб. 2022 г. в 18:36, Robert Nelson : > > > > > >>> Tested on J721E, J7200, DRA7xx, AM64x > > > >> > > > >> I'll try to test this on the AM335x boards I have as soon as possible. > > > > > > > > I wonder if we should

Re: [RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-11-30 Thread Matwey V. Kornilov
ср, 30 нояб. 2022 г. в 18:36, Robert Nelson : > > > >>> Tested on J721E, J7200, DRA7xx, AM64x > > >> > > >> I'll try to test this on the AM335x boards I have as soon as possible. > > > > > > I wonder if we should re-factor this code a bit and not have a single > > > ti_i2c_eeprom_get but instead

Re: [RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-11-30 Thread Robert Nelson
> >>> Tested on J721E, J7200, DRA7xx, AM64x > >> > >> I'll try to test this on the AM335x boards I have as soon as possible. > > > > I wonder if we should re-factor this code a bit and not have a single > > ti_i2c_eeprom_get but instead build for whichever sets of quirks a given > > family of

Re: [RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-11-29 Thread Neha Malcom Francis
Hi Tom On 29/11/22 19:01, Tom Rini wrote: On Tue, Nov 29, 2022 at 03:10:12PM +0300, Matwey V. Kornilov wrote: вт, 29 нояб. 2022 г. в 09:50, Neha Malcom Francis : EEPROM detection logic in ti_i2c_eeprom_get() involves figuring out whether addressing is 1-byte or 2-byte. There are currently

Re: [RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-11-29 Thread Neha Malcom Francis
Hi Matwey On 29/11/22 17:40, Matwey V. Kornilov wrote: вт, 29 нояб. 2022 г. в 09:50, Neha Malcom Francis : EEPROM detection logic in ti_i2c_eeprom_get() involves figuring out whether addressing is 1-byte or 2-byte. There are currently different behaviours seen across boards as documented in

Re: [RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-11-29 Thread Tom Rini
On Tue, Nov 29, 2022 at 03:10:12PM +0300, Matwey V. Kornilov wrote: > вт, 29 нояб. 2022 г. в 09:50, Neha Malcom Francis : > > > > EEPROM detection logic in ti_i2c_eeprom_get() involves figuring out > > whether addressing is 1-byte or 2-byte. There are currently different > > behaviours seen across

Re: [RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-11-29 Thread Matwey V. Kornilov
вт, 29 нояб. 2022 г. в 09:50, Neha Malcom Francis : > > EEPROM detection logic in ti_i2c_eeprom_get() involves figuring out > whether addressing is 1-byte or 2-byte. There are currently different > behaviours seen across boards as documented in commit bf6376642fe8 > ("board: ti: common:

[RFC PATCH] board: ti: common: board_detect: Fix EEPROM read quirk for 2-byte

2022-11-28 Thread Neha Malcom Francis
EEPROM detection logic in ti_i2c_eeprom_get() involves figuring out whether addressing is 1-byte or 2-byte. There are currently different behaviours seen across boards as documented in commit bf6376642fe8 ("board: ti: common: board_detect: Fix EEPROM read quirk"). Adding to the list, we see that