Re: [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness

2014-02-03 Thread York Sun
On 02/03/2014 01:35 PM, Scott Wood wrote: > On Mon, 2014-02-03 at 12:28 -0800, York Sun wrote: >> On 01/17/2014 10:58 PM, Prabhakar Kushwaha wrote: >>> IFC registers can be of type Little Endian or big Endian depending upon >>> Freescale SoC. Here SoC defines the register type of IFC IP. >>> >>> So

Re: [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness

2014-02-03 Thread Scott Wood
On Mon, 2014-02-03 at 12:28 -0800, York Sun wrote: > On 01/17/2014 10:58 PM, Prabhakar Kushwaha wrote: > > IFC registers can be of type Little Endian or big Endian depending upon > > Freescale SoC. Here SoC defines the register type of IFC IP. > > > > So update acessor functions with common IFC ac

Re: [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness

2014-02-03 Thread York Sun
On 01/17/2014 10:58 PM, Prabhakar Kushwaha wrote: > IFC registers can be of type Little Endian or big Endian depending upon > Freescale SoC. Here SoC defines the register type of IFC IP. > > So update acessor functions with common IFC acessor functions to take care > both type of endianness. > >

Re: [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness

2014-01-24 Thread York Sun
On 01/21/2014 09:34 AM, York Sun wrote: > On 01/21/2014 09:29 AM, Scott Wood wrote: >> On Tue, 2014-01-21 at 10:14 +0100, Wolfgang Denk wrote: >>> Dear York, >>> >>> In message you wrote: > On second thought, I also think we should avoid solutions where the > BE/LE test has to be done

Re: [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness

2014-01-21 Thread York Sun
On 01/21/2014 09:29 AM, Scott Wood wrote: > On Tue, 2014-01-21 at 10:14 +0100, Wolfgang Denk wrote: >> Dear York, >> >> In message you wrote: >>> On second thought, I also think we should avoid solutions where the BE/LE test has to be done for each and every I/O accessor call again

Re: [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness

2014-01-21 Thread Scott Wood
On Tue, 2014-01-21 at 10:14 +0100, Wolfgang Denk wrote: > Dear York, > > In message you wrote: > > > > > On second thought, I also think we should avoid solutions where the > > > BE/LE test has to be done for each and every I/O accessor call again > > > and again. We should rather do this just

Re: [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness

2014-01-21 Thread Wolfgang Denk
Dear York, In message you wrote: > > > On second thought, I also think we should avoid solutions where the > > BE/LE test has to be done for each and every I/O accessor call again > > and again. We should rather do this just once, and for example set > > function pointers as needed (hoping that

Re: [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness

2014-01-20 Thread Prabhakar Kushwaha
On 1/21/2014 12:04 PM, Wolfgang Denk wrote: Dear Scott, In message <20140121054228.de994382...@gemini.denx.de> I wrote: I fear that more IP blocks will follow that have similar requirements, and if we implemnt similar wrappers for each of them separately, we will have a mess of hard to maintai

Re: [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness

2014-01-20 Thread York Sun
Dear Wolfgang, On Jan 20, 2014, at 10:34 PM, Wolfgang Denk wrote: > Dear Scott, > > In message <20140121054228.de994382...@gemini.denx.de> I wrote: >> >> I fear that more IP blocks will follow that have similar requirements, >> and if we implemnt similar wrappers for each of them separately, we

Re: [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness

2014-01-20 Thread Wolfgang Denk
Dear Scott, In message <20140121054228.de994382...@gemini.denx.de> I wrote: > > I fear that more IP blocks will follow that have similar requirements, > and if we implemnt similar wrappers for each of them separately, we > will have a mess of hard to maintain code. For example, it will then > be

Re: [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness

2014-01-20 Thread Wolfgang Denk
Dear Scott, In message <1390258263.24905.337.ca...@snotra.buserror.net> you wrote: > > > As is, you are only adding dead code, as there is no place anywhere in > > the mainline code that defines CONFIG_SYS_FSL_IFC_LE > > Yes, consider it RFC until we have patches for a target that needs LE. This

Re: [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness

2014-01-20 Thread Scott Wood
On Sat, 2014-01-18 at 09:24 +0100, Wolfgang Denk wrote: > Dear Prabhakar Kushwaha, > > In message <1390028310-30861-1-git-send-email-prabha...@freescale.com> you > wrote: > > IFC registers can be of type Little Endian or big Endian depending upon > > Freescale SoC. Here SoC defines the register t

Re: [U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness

2014-01-18 Thread Wolfgang Denk
Dear Prabhakar Kushwaha, In message <1390028310-30861-1-git-send-email-prabha...@freescale.com> you wrote: > IFC registers can be of type Little Endian or big Endian depending upon > Freescale SoC. Here SoC defines the register type of IFC IP. As is, you are only adding dead code, as there is no

[U-Boot] [PATCH][v2] driver/ifc:Change accessor function to take care of endianness

2014-01-17 Thread Prabhakar Kushwaha
IFC registers can be of type Little Endian or big Endian depending upon Freescale SoC. Here SoC defines the register type of IFC IP. So update acessor functions with common IFC acessor functions to take care both type of endianness. Signed-off-by: Prabhakar Kushwaha --- Changes for v2: