Re: [U-Boot] [PATCH] ARM: Disable "DISCARD" for secure section if CONFIG_ARMV7_SECURE_BASE isn't defined

2016-01-17 Thread Dongsheng Wang
Hi Tom, Thanks for your review. I will update this patch. Regards, -Dongsheng > On Mon, Jan 11, 2016 at 02:51:39AM +, Dongsheng Wang wrote: > > Hi Tom, > > > > Sorry for my late reply, and thanks for your reply. > > > > How about the following comments, following your suggestion I remove >

Re: [U-Boot] [PATCH] ARM: Disable "DISCARD" for secure section if CONFIG_ARMV7_SECURE_BASE isn't defined

2016-01-14 Thread Tom Rini
On Mon, Jan 11, 2016 at 02:51:39AM +, Dongsheng Wang wrote: > Hi Tom, > > Sorry for my late reply, and thanks for your reply. > > How about the following comments, following your suggestion I remove some > redundant comments? > > If my understanding is wrong, please correct me, thanks: > #i

Re: [U-Boot] [PATCH] ARM: Disable "DISCARD" for secure section if CONFIG_ARMV7_SECURE_BASE isn't defined

2016-01-10 Thread Dongsheng Wang
Hi Tom, Sorry for my late reply, and thanks for your reply. How about the following comments, following your suggestion I remove some redundant comments? If my understanding is wrong, please correct me, thanks: #if defined(CONFIG_ARMV7_SECURE_BASE) && defined(CONFIG_ARMV7_NONSEC) /*

Re: [U-Boot] [PATCH] ARM: Disable "DISCARD" for secure section if CONFIG_ARMV7_SECURE_BASE isn't defined

2016-01-04 Thread Peng Fan
Hi Tom, On Mon, Jan 04, 2016 at 10:50:16AM -0500, Tom Rini wrote: >On Fri, Dec 11, 2015 at 03:30:24PM +, Dongsheng Wang wrote: >> Hi Tom, >> >> > On Fri, Dec 11, 2015 at 10:15:03AM +, Dongsheng Wang wrote: >> > > Hi Tom, >> > > >> > > Thanks for your review. >> > > >> > > > On Thu, Dec 10,

Re: [U-Boot] [PATCH] ARM: Disable "DISCARD" for secure section if CONFIG_ARMV7_SECURE_BASE isn't defined

2016-01-04 Thread Tom Rini
On Fri, Dec 11, 2015 at 03:30:24PM +, Dongsheng Wang wrote: > Hi Tom, > > > On Fri, Dec 11, 2015 at 10:15:03AM +, Dongsheng Wang wrote: > > > Hi Tom, > > > > > > Thanks for your review. > > > > > > > On Thu, Dec 10, 2015 at 10:49:01AM +0800, Dongsheng Wang wrote: > > > > > > > > > From: Wa

Re: [U-Boot] [PATCH] ARM: Disable "DISCARD" for secure section if CONFIG_ARMV7_SECURE_BASE isn't defined

2015-12-11 Thread Dongsheng Wang
Hi Tom, > On Fri, Dec 11, 2015 at 10:15:03AM +, Dongsheng Wang wrote: > > Hi Tom, > > > > Thanks for your review. > > > > > On Thu, Dec 10, 2015 at 10:49:01AM +0800, Dongsheng Wang wrote: > > > > > > > From: Wang Dongsheng > > > > > > > > Fix PSCI hang up without CONFIG_ARMV7_SECURE_BASE defi

Re: [U-Boot] [PATCH] ARM: Disable "DISCARD" for secure section if CONFIG_ARMV7_SECURE_BASE isn't defined

2015-12-11 Thread Tom Rini
On Fri, Dec 11, 2015 at 10:15:03AM +, Dongsheng Wang wrote: > Hi Tom, > > Thanks for your review. > > > On Thu, Dec 10, 2015 at 10:49:01AM +0800, Dongsheng Wang wrote: > > > > > From: Wang Dongsheng > > > > > > Fix PSCI hang up without CONFIG_ARMV7_SECURE_BASE define. > > > "DISCARD" will r

Re: [U-Boot] [PATCH] ARM: Disable "DISCARD" for secure section if CONFIG_ARMV7_SECURE_BASE isn't defined

2015-12-11 Thread Dongsheng Wang
Hi Tom, Thanks for your review. > On Thu, Dec 10, 2015 at 10:49:01AM +0800, Dongsheng Wang wrote: > > > From: Wang Dongsheng > > > > Fix PSCI hang up without CONFIG_ARMV7_SECURE_BASE define. > > "DISCARD" will remove ._secure.text relocate, but PSCI framework has > > already used some absolute

Re: [U-Boot] [PATCH] ARM: Disable "DISCARD" for secure section if CONFIG_ARMV7_SECURE_BASE isn't defined

2015-12-10 Thread Tom Rini
On Thu, Dec 10, 2015 at 10:49:01AM +0800, Dongsheng Wang wrote: > From: Wang Dongsheng > > Fix PSCI hang up without CONFIG_ARMV7_SECURE_BASE define. > "DISCARD" will remove ._secure.text relocate, but PSCI framework > has already used some absolute address those need to relocate. > > Use readel

[U-Boot] [PATCH] ARM: Disable "DISCARD" for secure section if CONFIG_ARMV7_SECURE_BASE isn't defined

2015-12-09 Thread Dongsheng Wang
From: Wang Dongsheng Fix PSCI hang up without CONFIG_ARMV7_SECURE_BASE define. "DISCARD" will remove ._secure.text relocate, but PSCI framework has already used some absolute address those need to relocate. Use readelf -t -r u-boot show us: .__secure_start addr: 601408e4 .__secure_end