Re: [U-Boot] [PATCH] ARM: at91: sama5d2: Wrap cpu detection to fix macb driver

On 22.03.2019 15:25, Alexander Dahl wrote: > When introducing the SAMA5D27 SoCs, the SAMA5D2 series got an additional > chip id. The check if the cpu is sama5d2 was changed from a preprocessor > definition (inlining a call to 'get_chip_id()') to a C function, > probably to not call get_chip_id t

Re: [U-Boot] [PATCH] ARM: at91: sama5d2: Wrap cpu detection to fix macb driver

Hello Eugen, Am Montag, 25. März 2019, 09:46:02 CET schrieb eugen.hris...@microchip.com: > Are you sure there is a problem with this commit itself: > > net: macb: Fix GEM hardware detection > > as it looks , this commit fixes the interpretation of the MID register > w.r.t. the gem capability...

Re: [U-Boot] [PATCH] ARM: at91: sama5d2: Wrap cpu detection to fix macb driver

On 25.03.2019 11:17, Alexander Dahl wrote: > Hei hei, > > one thing still puzzled me, why did it work on SAMA5D27-SOM1-EK1 board, but > not on our custom board? I think I know the reason now. > > As Nicolas Ferre replied on my confusion on that MID register, on SAMA5D2 that > register reads 0x

Re: [U-Boot] [PATCH] ARM: at91: sama5d2: Wrap cpu detection to fix macb driver

Hei hei, one thing still puzzled me, why did it work on SAMA5D27-SOM1-EK1 board, but not on our custom board? I think I know the reason now. As Nicolas Ferre replied on my confusion on that MID register, on SAMA5D2 that register reads 0x00020203, so the value extracted for determining if that

Re: [U-Boot] [PATCH] ARM: at91: sama5d2: Wrap cpu detection to fix macb driver

Greetings Alex and everyone, Currently I'm trying to block all some PC applications that is appearing as hidden, system files as well as unknown files on my mobile phones, and any related to my laptop. It's blocking me from writing proper commands. And upon every restore, reinstall etc, I will ha

Re: [U-Boot] [PATCH] ARM: at91: sama5d2: Wrap cpu detection to fix macb driver

Hei hei, my use of git send-email messed up my original cc list, so I add Eugen as maintainer for at91 here. I have some additional comments below. On Fri, Mar 22, 2019 at 02:25:54PM +0100, Alexander Dahl wrote: > The not working check on the SAMA5D2 CPU lead to an issue on a custom > board with

[U-Boot] [PATCH] ARM: at91: sama5d2: Wrap cpu detection to fix macb driver

When introducing the SAMA5D27 SoCs, the SAMA5D2 series got an additional chip id. The check if the cpu is sama5d2 was changed from a preprocessor definition (inlining a call to 'get_chip_id()') to a C function, probably to not call get_chip_id twice? That however broke a check in the macb ethernet