Re: [U-Boot] [PATCH] ARMv7: OMAP: Add init function for TWL4030 GBPR1 register

2012-03-05 Thread Tom Rini
On Sun, Mar 4, 2012 at 12:45 AM, Igor Grinberg wrote: > On 03/01/12 19:47, Jonathan Solnit wrote: >> Hi Igor. >> >> On Thu, Mar 1, 2012 at 12:41 AM, Igor Grinberg > > wrote: >> >>     Hi Jonathan, >> >>     On 02/29/12 22:52, Jonathan Solnit wrote: >>     > The OMAP

Re: [U-Boot] [PATCH] ARMv7: OMAP: Add init function for TWL4030 GBPR1 register

2012-03-05 Thread Jonathan Solnit
> > > We would really appreciate if someone from TI (Tom?) can confirm that this > is a bug in ROM code. > Nevertheless, I don't think U-Boot uses MADC feature (am I right?), > so IMO, kernel has to be fixed (I think already fixed) to not rely > on ROM/U-Boot setup of that MADC clock. > > I can say

Re: [U-Boot] [PATCH] ARMv7: OMAP: Add init function for TWL4030 GBPR1 register

2012-03-03 Thread Igor Grinberg
On 03/01/12 19:47, Jonathan Solnit wrote: > Hi Igor. > > On Thu, Mar 1, 2012 at 12:41 AM, Igor Grinberg > wrote: > > Hi Jonathan, > > On 02/29/12 22:52, Jonathan Solnit wrote: > > The OMAP ROM code modifies the GBPR1 register, which can cause > >

Re: [U-Boot] [PATCH] ARMv7: OMAP: Add init function for TWL4030 GBPR1 register

2012-03-01 Thread Jonathan Solnit
Hi Igor. On Thu, Mar 1, 2012 at 12:41 AM, Igor Grinberg wrote: > Hi Jonathan, > > On 02/29/12 22:52, Jonathan Solnit wrote: > > The OMAP ROM code modifies the GBPR1 register, which can cause > > s/GBPR1/GPBR1/ > > > unintended consequences. > > What do you mean by this? > Can you please elaborate

Re: [U-Boot] [PATCH] ARMv7: OMAP: Add init function for TWL4030 GBPR1 register

2012-03-01 Thread Igor Grinberg
Hi Jonathan, On 02/29/12 22:52, Jonathan Solnit wrote: > The OMAP ROM code modifies the GBPR1 register, which can cause s/GBPR1/GPBR1/ > unintended consequences. What do you mean by this? Can you please elaborate, what issues do you see? Also, why does the OMAP ROM code needs to touch the GPBR

[U-Boot] [PATCH] ARMv7: OMAP: Add init function for TWL4030 GBPR1 register

2012-02-29 Thread Jonathan Solnit
The OMAP ROM code modifies the GBPR1 register, which can cause unintended consequences. This patch adds a function to restore GBPR1 to its default value. Signed-off-by: Jonathan Solnit --- drivers/power/twl4030.c |8 include/twl4030.h | 17 + 2 files changed