Re: [U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x family

2009-09-21 Thread Fabio Estevam
Hi Martha, --- On Mon, 9/21/09, Martha M Stan wrote: > From: Martha M Stan > Subject: [U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x > family > To: u-boot@lists.denx.de > Cc: "Martha M Stan" > Date: Monday, September 21, 2009, 5:27 PM &g

Re: [U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x family

2009-10-03 Thread Wolfgang Denk
Dear Martha M Stan, do you plan to send an updated patch for this release? In addition to Fabio's comments here a few more: In message <12535648622828-git-send-email-mm...@silicontkx.com> you wrote: > ... > diff --git a/board/freescale/mpc5125ads/mpc5125ads.c > b/board/freescale/mpc5125ads/mpc5

Re: [U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x family

2009-10-04 Thread m marx
ginal Message- From: Wolfgang Denk w...@denx.de Sent 10/3/2009 6:43:51 PM To: Martha M Stan mm...@silicontkx.com Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x family Dear Martha M Stan, do you plan to send an updated patch for this re

Re: [U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x family

2009-10-04 Thread Wolfgang Denk
Dear Martha, umm... your mail header still says "m marx". In message <20091004102089.sm01...@[206.180.163.89]> you wrote: > > I am planning to resubmit this patch very soon - by Tuesday perhaps. > Considering there is some differences in the memory layout esp for the > iopin struct (going from 3

Re: [U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x family

2009-10-13 Thread Wolfgang Denk
Dear Martha Stan, In message <1254987657-10103-1-git-send-email-mm...@silicontkx.com> you wrote: > Signed-off-by: Martha Stan > --- > MAINTAINERS |5 + > MAKEALL |1 + > Makefile|3 + > board/

Re: [U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x family

2009-10-13 Thread m stan
Hi Wolfgang, I had to chuckle when I read your opening paragraph – let me say that I have never thought of myself as a victim – even at the hands of these FSL silicon guys!!! But I did get a pretty raw deal – yes. Now I am going to respond a little before I go and resubmit. Very Best Regards,

Re: [U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x family

2009-10-18 Thread Wolfgang Denk
Dear Martha, In message <200910131345510.sm02...@[206.180.163.89]> you wrote: > > >We should avoid adding stuff to asm-offsets.h; instead, we should > >finally auto-generate this file from the respective C structs as it's > >done in Linux. Do you dare to tackle this? > > I can't do this any tim

Re: [U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x family

2009-10-19 Thread John Rigby
Regarding 512x psc register maps: The register map for 5125 does not just change the size of the registers. Some registers change locations. The issue is that the hardware guys decided to "fix" the old broken register access. The 5200, 5121, 5123 had some registers that were: Function A when re

Re: [U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x family

2009-10-20 Thread m stan
> > Yes but the default has constants like CONFIG_SYS_MICRON_INIT_DEV_OP > > ... must I then declare this if I am using > > CONFIG_SYS_ELPIDA_INIT_DEV_OP ? > Well, the ideas was that this was the default setting that fits most > boards, and if it doesn't fit it will be overwritten by another arra

Re: [U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x family

2009-10-20 Thread Wolfgang Denk
Dear Martha, can you _please_ fix your mailer and make sure to keep the In-reply-to: and References: mail headers in place and working, so threading of messages works? Thanks. In message <200910200953803.sm05...@[206.180.163.89]> you wrote: > > > Well, the ideas was that this was the default se

Re: [U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x family

2009-10-20 Thread Wolfgang Denk
Dear John, In message <4b73d43f0910191545x3127cba5w7fdec3f638213...@mail.gmail.com> you wrote: > > The register map for 5125 does not just change the size of the registers. > Some registers change locations. The issue is that the hardware guys > decided to "fix" the old broken register access.

Re: [U-Boot] [PATCH] Add mpc5125ads board and processor to the mpc512x family

2009-10-21 Thread Kenneth Johansson
On Mon, 2009-10-19 at 16:45 -0600, John Rigby wrote: > Regarding 512x psc register maps: > > The register map for 5125 does not just change the size of the registers. > Some registers change locations. The issue is that the hardware guys > decided to "fix" the old broken register access. The 520