[U-Boot] [PATCH] Add support for the digsy MTC board.

2009-02-12 Thread Grzegorz Bernacki
This is the InterControl custom device based on the MPC5200B chip. Signed-off-by: Grzegorz Bernacki --- Version 4: - rebased to Ben's FEC changes Version 3: - updated (c) Version 2: - use I/O accessor functions instead of volatile pointer - set ethernet address only if not set in environment

[U-Boot] [PATCH] Add support for the digsy MTC board.

2009-01-28 Thread Grzegorz Bernacki
This is the InterControl custom device based on the MPC5200B chip. Signed-off-by: Grzegorz Bernacki diff --git a/MAKEALL b/MAKEALL index 530fe82..530651d 100755 --- a/MAKEALL +++ b/MAKEALL @@ -47,6 +47,7 @@ LIST_5xxx=" \ BC3450 \ cm5200 \ cpci5

Re: [U-Boot] [PATCH] Add support for the digsy MTC board.

2009-02-12 Thread Stefan Roese
On Thursday 12 February 2009, Grzegorz Bernacki wrote: > This is the InterControl custom device based on the MPC5200B chip. > > Signed-off-by: Grzegorz Bernacki Please find some comments below. > diff --git a/board/digsy_mtc/digsy_mtc.c b/board/digsy_mtc/digsy_mtc.c > new file mode 100644 > inde

Re: [U-Boot] [PATCH] Add support for the digsy MTC board.

2009-01-28 Thread Wolfgang Denk
Dear Grzegorz, In message <12331552753467-git-send-email-...@semihalf.com> you wrote: > This is the InterControl custom device based on the MPC5200B chip. ... General comment: there is a lot of code which could use a few comments so the reader has a chance to understand what exactly you are doing

Re: [U-Boot] [PATCH] Add support for the digsy MTC board.

2009-01-29 Thread Grzegorz Bernacki
Wolfgang Denk wrote: > Dear Grzegorz, > > In message <12331552753467-git-send-email-...@semihalf.com> you wrote: >> This is the InterControl custom device based on the MPC5200B chip. > ... > > General comment: there is a lot of code which could use a few comments > so the reader has a chance to u

Re: [U-Boot] [PATCH] Add support for the digsy MTC board.

2009-01-29 Thread Wolfgang Denk
Dear Grzegorz Bernacki, In message <49816f40.3000...@semihalf.com> you wrote: > > > General comment: there is a lot of code which could use a few comments > > so the reader has a chance to understand what exactly you are doing. > > > > Could you point me out which parts of code except eeprom def

Re: [U-Boot] [PATCH] Add support for the digsy MTC board.

2009-01-29 Thread Grzegorz Bernacki
Wolfgang Denk wrote: > Dear Grzegorz Bernacki, > > In message <49816f40.3000...@semihalf.com> you wrote: >>> General comment: there is a lot of code which could use a few comments >>> so the reader has a chance to understand what exactly you are doing. >>> >> Could you point me out which parts of

Re: [U-Boot] [PATCH] Add support for the digsy MTC board.

2009-01-29 Thread Jerry Van Baren
Wolfgang Denk wrote: > Dear Grzegorz Bernacki, > > In message <49816f40.3000...@semihalf.com> you wrote: [snip] * This program is distributed in the hope that it will be useful, * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR

Re: [U-Boot] [PATCH] Add support for the digsy MTC board.

2009-02-03 Thread Grzegorz Bernacki
Wolfgang Denk wrote: > Dear Grzegorz, > > In message <12331552753467-git-send-email-...@semihalf.com> you wrote: >> This is the InterControl custom device based on the MPC5200B chip. > ... > > General comment: there is a lot of code which could use a few comments > so the reader has a chance to u