Re: [U-Boot] [PATCH] Adding support for DevKit8000

2009-08-21 Thread Wolfgang Denk
Dear Jean-Christophe PLAGNIOL-VILLARD, In message 20090820132229.gt8...@game.jcrosoft.org you wrote: ok, I think this will break nfsroot. I don't think it's possible to init ethernet with a initramfs before mounting the rootfs. pivot root is your friend and generate the mac address at

Re: [U-Boot] [PATCH] Adding support for DevKit8000

2009-08-20 Thread Frederik Kriewitz
On Thu, Aug 20, 2009 at 12:19 AM, Jean-Christophe PLAGNIOL-VILLARDplagn...@jcrosoft.com wrote: board/omap3/devkit8000/Makefile | 52 + board/omap3/devkit8000/config.mk| 35 board/omap3/devkit8000/devkit8000.c | 124 board/omap3/devkit8000/devkit8000.h | 373

Re: [U-Boot] [PATCH] Adding support for DevKit8000

2009-08-20 Thread Jean-Christophe PLAGNIOL-VILLARD
On 10:55 Thu 20 Aug , Frederik Kriewitz wrote: On Thu, Aug 20, 2009 at 12:19 AM, Jean-Christophe PLAGNIOL-VILLARDplagn...@jcrosoft.com wrote: board/omap3/devkit8000/Makefile | 52 + board/omap3/devkit8000/config.mk| 35 board/omap3/devkit8000/devkit8000.c | 124

Re: [U-Boot] [PATCH] Adding support for DevKit8000

2009-08-19 Thread Jean-Christophe PLAGNIOL-VILLARD
On 01:20 Tue 18 Aug , Frederik Kriewitz wrote: This patch adds support for the DevKit8000 board. Signed-off-by: Frederik Kriewitz frede...@kriewitz.eu --- mach-types.h needs to be synced (MACH_TYPE_DEVKIT8000) --- MAINTAINERS |4 + Makefile

Re: [U-Boot] [PATCH] Adding support for DevKit8000

2009-08-19 Thread Frederik Kriewitz
I'll fix that. On Thu, Aug 20, 2009 at 12:19 AM, Jean-Christophe PLAGNIOL-VILLARDplagn...@jcrosoft.com wrote: +void reset_phy(void) +{ +     eth_init(gd-bd); +} NACK the net need to be init only when you use it The kernel will try to use the already (temporally) programmed MAC address. I

Re: [U-Boot] [PATCH] Adding support for DevKit8000

2009-08-19 Thread Jean-Christophe PLAGNIOL-VILLARD
On 05:59 Thu 20 Aug , Frederik Kriewitz wrote: I'll fix that. On Thu, Aug 20, 2009 at 12:19 AM, Jean-Christophe PLAGNIOL-VILLARDplagn...@jcrosoft.com wrote: +void reset_phy(void) +{ +     eth_init(gd-bd); +} NACK the net need to be init only when you use it The kernel will

[U-Boot] [PATCH] Adding support for DevKit8000

2009-08-17 Thread Frederik Kriewitz
This patch adds support for the DevKit8000 board. Signed-off-by: Frederik Kriewitz frede...@kriewitz.eu --- Makefile|3 + board/omap3/devkit8000/Makefile | 51 + board/omap3/devkit8000/config.mk| 34 +++ board/omap3/devkit8000/devkit8000.c | 117

Re: [U-Boot] [PATCH] Adding support for DevKit8000

2009-08-17 Thread Wolfgang Denk
Dear Frederik Kriewitz, In message 1250500736-20034-1-git-send-email-frede...@kriewitz.eu you wrote: This patch adds support for the DevKit8000 board. Signed-off-by: Frederik Kriewitz frede...@kriewitz.eu --- Makefile|3 + board/omap3/devkit8000/Makefile

Re: [U-Boot] [PATCH] Adding support for DevKit8000

2009-08-17 Thread Frederik Kriewitz
Thank you for reviewing my patch. I've fixed the issues and will submit it again once Jean-Christophe updated the mach-types.h. On Mon, Aug 17, 2009 at 11:50 AM, Wolfgang Denkw...@denx.de wrote: +#define CONFIG_SYS_MAX_FLASH_SECT    520     /* max number of sectors on */ +                      

Re: [U-Boot] [PATCH] Adding support for DevKit8000

2009-08-17 Thread Dirk Behme
Frederik Kriewitz wrote: Thank you for reviewing my patch. I've fixed the issues and will submit it again once Jean-Christophe updated the mach-types.h. Please send an official request for this. See http://lists.denx.de/pipermail/u-boot/2008-September/040553.html Best regards Dirk On

Re: [U-Boot] [PATCH] Adding support for DevKit8000

2009-08-17 Thread Dirk Behme
Frederik Kriewitz wrote: This patch adds support for the DevKit8000 board. Wolfgang commented already most of the topics. So, only one comment left for me: ... +++ b/board/omap3/devkit8000/devkit8000.c ... +/* + * Routine: misc_init_r + * Description: Configure board specific parts + */

Re: [U-Boot] [PATCH] Adding support for DevKit8000

2009-08-17 Thread Frederik Kriewitz
On Mon, Aug 17, 2009 at 5:21 PM, Dirk Behmedirk.be...@googlemail.com wrote: With the OMAP DIE_ID thread we know what you are doing here. But do we want to have this really in mainline? It looks to me like a workaround for broken hardware (that is, having no proper MAC address configured)? Or do

Re: [U-Boot] [PATCH] Adding support for DevKit8000

2009-08-17 Thread Dirk Behme
Frederik Kriewitz wrote: On Mon, Aug 17, 2009 at 5:21 PM, Dirk Behmedirk.be...@googlemail.com wrote: With the OMAP DIE_ID thread we know what you are doing here. But do we want to have this really in mainline? It looks to me like a workaround for broken hardware (that is, having no proper MAC

Re: [U-Boot] [PATCH] Adding support for DevKit8000

2009-08-17 Thread Dirk Behme
Dirk Behme wrote: Frederik Kriewitz wrote: Thank you for reviewing my patch. I've fixed the issues and will submit it again once Jean-Christophe updated the mach-types.h. Please send an official request for this. See http://lists.denx.de/pipermail/u-boot/2008-September/040553.html

Re: [U-Boot] [PATCH] Adding support for DevKit8000

2009-08-17 Thread Wolfgang Denk
Dear Dirk Behme, In message 4a897571.9090...@googlemail.com you wrote: Wolfgang commented already most of the topics. :-) So, only one comment left for me: But a well spottet one, thanks! + /* Use OMAP DIE_ID as MAC address */ + if (!eth_getenv_enetaddr(ethaddr, enetaddr)) { +

[U-Boot] [PATCH] Adding support for DevKit8000

2009-08-17 Thread Frederik Kriewitz
This patch adds support for the DevKit8000 board. Signed-off-by: Frederik Kriewitz frede...@kriewitz.eu --- mach-types.h needs to be synced (MACH_TYPE_DEVKIT8000) --- MAINTAINERS |4 + Makefile|3 + board/omap3/devkit8000/Makefile |