Re: [U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of OMAP34XX macros.

2009-11-20 Thread Måns Rullgård
Robert P. J. Day rpj...@crashcourse.ca writes: On Thu, 19 Nov 2009, Nishanth Menon wrote: I agree - I do not think there are any such plans. NAK to the patch. Regards, Nishanth Menon fair enough. but i think a two-line comment is still useful for people new to ARM who know the beagle

[U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of OMAP34XX macros.

2009-11-19 Thread Robert P. J. Day
Make it clear to a reader that the user of OMAP34XX macros in the (OMAP 3530-based) beagle config file is just fine. Signed-off-by: Robert P. J. Day rpj...@crashcourse.ca --- i'll let dirk be the judge as to whether this is worth adding, or if he'd prefer a different phrasing. diff --git

Re: [U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of OMAP34XX macros.

2009-11-19 Thread Måns Rullgård
Robert P. J. Day rpj...@crashcourse.ca writes: Make it clear to a reader that the user of OMAP34XX macros in the (OMAP 3530-based) beagle config file is just fine. Signed-off-by: Robert P. J. Day rpj...@crashcourse.ca --- i'll let dirk be the judge as to whether this is worth adding, or

Re: [U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of OMAP34XX macros.

2009-11-19 Thread Nishanth Menon
2009/11/19 Måns Rullgård m...@mansr.com: Robert P. J. Day rpj...@crashcourse.ca writes: Make it clear to a reader that the user of OMAP34XX macros in the (OMAP 3530-based) beagle config file is just fine. Signed-off-by: Robert P. J. Day rpj...@crashcourse.ca ---   i'll let dirk be the

Re: [U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of OMAP34XX macros.

2009-11-19 Thread Robert P. J. Day
On Fri, 20 Nov 2009, M?ns Rullg?rd wrote: Robert P. J. Day rpj...@crashcourse.ca writes: Make it clear to a reader that the user of OMAP34XX macros in the (OMAP 3530-based) beagle config file is just fine. Signed-off-by: Robert P. J. Day rpj...@crashcourse.ca --- i'll let dirk

Re: [U-Boot] [PATCH] BeagleBoard: Add a comment explaining the use of OMAP34XX macros.

2009-11-19 Thread Robert P. J. Day
On Thu, 19 Nov 2009, Nishanth Menon wrote: I agree - I do not think there are any such plans. NAK to the patch. Regards, Nishanth Menon fair enough. but i think a two-line comment is still useful for people new to ARM who know the beagle is a 3530 and wonder why all the macros use 34XX.