[U-Boot] [PATCH] CFI Driver: Reset watchdog timer after each flash operation

2009-10-02 Thread Ingo van Lil
The CFI driver does not reset the device's watchdog, so long-running flash operations will cause the watchdog timer to expire. A comment in flash_status_check() suggests that udelay() is expected to reset the watchdog, but I can't find any architecture where it does. Signed-off-by: Ingo van Lil -

Re: [U-Boot] [PATCH] CFI Driver: Reset watchdog timer after each flash operation

2009-10-02 Thread Stefan Roese
Hi Ingo, On Friday 02 October 2009 12:34:17 Ingo van Lil wrote: > The CFI driver does not reset the device's watchdog, so long-running > flash operations will cause the watchdog timer to expire. A comment in > flash_status_check() suggests that udelay() is expected to reset the > watchdog, but I c

Re: [U-Boot] [PATCH] CFI Driver: Reset watchdog timer after each flash operation

2009-10-02 Thread Ingo van Lil
On 10/02/2009 01:06 PM, Stefan Roese wrote: >> The CFI driver does not reset the device's watchdog, so long-running >> flash operations will cause the watchdog timer to expire. A comment in >> flash_status_check() suggests that udelay() is expected to reset the >> watchdog, but I can't find any ar

Re: [U-Boot] [PATCH] CFI Driver: Reset watchdog timer after each flash operation

2009-10-02 Thread Wolfgang Denk
Dear Ingo van Lil, In message <20091002103417.ga9...@zaphod.peppercon.de> you wrote: > The CFI driver does not reset the device's watchdog, so long-running > flash operations will cause the watchdog timer to expire. A comment in > flash_status_check() suggests that udelay() is expected to reset th

Re: [U-Boot] [PATCH] CFI Driver: Reset watchdog timer after each flash operation

2009-10-02 Thread Mike Frysinger
On Friday 02 October 2009 08:30:51 Wolfgang Denk wrote: > Ingo van Lil wrote: > > The CFI driver does not reset the device's watchdog, so long-running > > flash operations will cause the watchdog timer to expire. A comment in > > flash_status_check() suggests that udelay() is expected to reset the

Re: [U-Boot] [PATCH] CFI Driver: Reset watchdog timer after each flash operation

2009-10-02 Thread Wolfgang Denk
Dear Mike Frysinger, In message <200910021431.23079.vap...@gentoo.org> you wrote: > > Blackfin is missing it as well as i really had no idea it was supposed to be > there. certainly no doc states this requirement. perhaps it'd make sense to > break apart the common stuff to a common udelay() t

Re: [U-Boot] [PATCH] CFI Driver: Reset watchdog timer after each flash operation

2009-10-02 Thread J. William Campbell
Mike Frysinger wrote: > On Friday 02 October 2009 08:30:51 Wolfgang Denk wrote: > >> Ingo van Lil wrote: >> >>> The CFI driver does not reset the device's watchdog, so long-running >>> flash operations will cause the watchdog timer to expire. A comment in >>> flash_status_check() suggests t

Re: [U-Boot] [PATCH] CFI Driver: Reset watchdog timer after each flash operation

2009-10-02 Thread Wolfgang Denk
Dear "J. William Campbell", In message <4ac660e3.4010...@comcast.net> you wrote: > > At this point it might be appropriate to ask if including such a reset > in udelay() is a good idea. The way it is, no "infinite loop" in u-boot > that contains a udelay() will ever allow the watchdog to time ou

Re: [U-Boot] [PATCH] CFI Driver: Reset watchdog timer after each flash operation

2009-10-03 Thread Wolfgang Denk
Dear Ingo van Lil, In message <4ac5ee3b.5090...@gmx.de> you wrote: > > > PPC does it this way. udelay() in lib_ppc/time.c calls wait_ticks(). And > > here > > you will find WATCHDOG_RESET. > > You're right. Seems to be an exception, though: According to ctags there No, not an exception, but th

Re: [U-Boot] [PATCH] CFI Driver: Reset watchdog timer after each flash operation

2009-10-04 Thread Ingo van Lil
On 10/04/2009 01:29 AM, Wolfgang Denk wrote: > No, not an exception, but the reference implementation. I cannot help > it that most other architectures / SoCs don;t care much. Well, if such an uncommon side-effect is expected of a function with a well-known name it should at least be prominently

Re: [U-Boot] [PATCH] CFI Driver: Reset watchdog timer after each flash operation

2009-10-04 Thread Graeme Russ
On Sun, Oct 4, 2009 at 10:15 PM, Ingo van Lil wrote: > On 10/04/2009 01:29 AM, Wolfgang Denk wrote: > >> No, not an exception, but the reference implementation. I cannot help >> it that most other architectures / SoCs don;t care much. > > Well, if such an uncommon side-effect is expected of a func