[U-Boot] [PATCH] DA8xx: fix LPSC numbering

2011-03-21 Thread Laurence Withers
Hi, I'm in the process of porting u-boot to a new board we have developed using the OMAP-L138 (or DA850). While I'm a long way from finishing the port, I have noticed that the definitions of some of the local power and sleep controller (LPSC) register module numbers are incorrect. As a reply to t

[U-Boot] [PATCH] DA8xx: fix LPSC numbering

2011-03-21 Thread Laurence Withers
The DA8xx chips have two modules PSC0 and PSC1 for the local power and sleep controllers (LPSC). Each LPSC has up to 32 submodules over which it has control, which are enumerated by the DAVINCI_LPSC_* symbols. This commit fixes the definitions of a number of symbols to be consistent with both the

Re: [U-Boot] [PATCH] DA8xx: fix LPSC numbering

2011-03-21 Thread Wolfgang Denk
Dear Laurence Withers, In message you wrote: > The DA8xx chips have two modules PSC0 and PSC1 for the local power and sleep > controllers (LPSC). Each LPSC has up to 32 submodules over which it has > control, > which are enumerated by the DAVINCI_LPSC_* symbols. > > This commit fixes the defi

Re: [U-Boot] [PATCH] DA8xx: fix LPSC numbering

2011-03-21 Thread Wolfgang Denk
Dear Laurence Withers, In message you wrote: > > I'm in the process of porting u-boot to a new board we have developed using > the > OMAP-L138 (or DA850). While I'm a long way from finishing the port, I have > noticed that the definitions of some of the local power and sleep controller > (LPSC)

Re: [U-Boot] [PATCH] DA8xx: fix LPSC numbering

2011-03-21 Thread Wolfgang Denk
Dear Laurence Withers, In message <20110321203839.ga15...@lwithers.me.uk> you wrote: > > > Please fix also all other places where these identifiers are used in > > the code. > > The identifiers changed in the patch were not used anywhere in the code. I > also verified that a "./MAKEALL -s davinci

Re: [U-Boot] [PATCH] DA8xx: fix LPSC numbering

2011-03-21 Thread Laurence Withers
On Mon, Mar 21, 2011 at 07:43:51PM +0100, Wolfgang Denk wrote: > SoB missing. > > Lines in commit message too long. Thanks; I have fixed and will resend. > Please fix also all other places where these identifiers are used in > the code. The identifiers changed in the patch were not used anywher

Re: [U-Boot] [PATCH] DA8xx: fix LPSC numbering

2011-03-21 Thread Laurence Withers
On Mon, Mar 21, 2011 at 10:14:18PM +0100, Wolfgang Denk wrote: > -> grep -R DAVINCI_LPSC_TPCC * > arch/arm/include/asm/arch-davinci/hardware.h:#define DAVINCI_LPSC_TPCC > 2 > arch/arm/include/asm/arch-davinci/hardware.h: DAVINCI_LPSC_TPCC = 0, > board/davinci/dm355evm/dm355evm.c: l

Re: [U-Boot] [PATCH] DA8xx: fix LPSC numbering

2011-03-21 Thread Wolfgang Denk
Dear Laurence Withers, In message <20110321212544.gb15...@lwithers.me.uk> you wrote: > > Looking at the hardware.h file that I changed, just above the enum { } block > where my changes reside are a set of #defines for the same symbols. The > #defines are used when CONFIG_SOC_DA8XX is not defined;

Re: [U-Boot] [PATCH] DA8xx: fix LPSC numbering

2011-03-21 Thread Laurence Withers
On Mon, Mar 21, 2011 at 10:44:11PM +0100, Wolfgang Denk wrote: > We should agree on a common way to implement this - either #define > _or_ enum, but not a mix of both. > > Having a closer look, it turns out that all these "indices" are > actually register names, and functions like lpsc_on() use ho