On Thursday, April 10, 2014 at 12:15:30 PM, Wolfgang Denk wrote:
> Dear Marek,
>
> In message <201404101012.42527.ma...@denx.de> you wrote:
> > On Sunday, April 06, 2014 at 01:17:46 PM, Wolfgang Denk wrote:
> > [...]
> >
> > > @@ -131,7 +133,9 @@ void usb_kbd_generic_poll(void)
> > >
> > > /*
Dear Marek,
In message <201404101012.42527.ma...@denx.de> you wrote:
> On Sunday, April 06, 2014 at 01:17:46 PM, Wolfgang Denk wrote:
> [...]
>
> > @@ -131,7 +133,9 @@ void usb_kbd_generic_poll(void)
> > /* Submit a interrupt transfer request */
> > maxp = usb_maxpacket(usb_kbd_dev, pipe);
On Thursday, April 10, 2014 at 10:49:56 AM, Adrian Cox wrote:
> > From: "Marek Vasut"
> >
> > Also, this USB_KBD_PDATA_SIZE should instead be called
> > "USB_KBD_LS_REPORT_SIZE"
> > [...]
> > What worries me a bit is that 64-byte high-speed report, but I never
> > saw a
> > device that would gene
> From: "Marek Vasut"
> Also, this USB_KBD_PDATA_SIZE should instead be called
> "USB_KBD_LS_REPORT_SIZE"
> [...]
> What worries me a bit is that 64-byte high-speed report, but I never
> saw a
> device that would generate those. This section 5.6 is also the only
> place that
> mentions the high-s
On Sunday, April 06, 2014 at 01:17:46 PM, Wolfgang Denk wrote:
[...]
> @@ -131,7 +133,9 @@ void usb_kbd_generic_poll(void)
> /* Submit a interrupt transfer request */
> maxp = usb_maxpacket(usb_kbd_dev, pipe);
> usb_submit_int_msg(usb_kbd_dev, pipe, data->new,
> -
Dear Adrian,
In message <3392231.3254.1396864604431.JavaMail.adrian@Gurnard> you wrote:
>
> > From: "Wolfgang Denk"
>
> > I agree that the code is wrong and needs fixing. data->new is an
> > uint8_t pointer, so taking the size of the pointer is obviously
> > wrong. But what you fix here is no
> From: "Wolfgang Denk"
> I agree that the code is wrong and needs fixing. data->new is an
> uint8_t pointer, so taking the size of the pointer is obviously
> wrong. But what you fix here is not the only place where
> sizeof(data->new) is used, so this patch fixes part of the problem at
> best
Dear Adrian Cox,
In message <4526969.2646.1396715845133.JavaMail.adrian@Gurnard> you wrote:
>
> USB keyboard polling failed for some keyboards on PowerPC 5020.
> This was caused by requesting only 4 bytes of data from keyboards that
> produce an 8 byte HID report.
>
> Signed-off-by: Adrian Cox
USB keyboard polling failed for some keyboards on PowerPC 5020.
This was caused by requesting only 4 bytes of data from keyboards that
produce an 8 byte HID report.
Signed-off-by: Adrian Cox
---
common/usb_kbd.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/
9 matches
Mail list logo
