Re: [U-Boot] [PATCH] Fix board init code to use a valid C runtime environment

2015-11-10 Thread Albert ARIBAUD
Hello Simon, On Tue, 10 Nov 2015 13:04:50 -0700, Simon Glass wrote: > I'm hoping we don't have to bring back this assembler. What we need in ASM is just the part that actually alters the stack (i.e., changes the SP of the architecture) so that no C function has to do it. > Do we really need to

Re: [U-Boot] [PATCH] Fix board init code to use a valid C runtime environment

2015-11-10 Thread Simon Glass
Hi Albert, On 9 November 2015 at 17:20, Albert ARIBAUD wrote: > board_init_f_mem() alters the C runtime environment's > stack it ls actually already using. This is not a valid > C runtime environment and may conflict with the C compiler's > expectations. > > Split board_init_f_mem into C function

Re: [U-Boot] [PATCH] Fix board init code to use a valid C runtime environment (LONG, sorry)

2015-11-09 Thread Albert ARIBAUD
Hello Bin, On Tue, 10 Nov 2015 11:54:08 +0800, Bin Meng wrote: > Hi Albert, > > On Tue, Nov 10, 2015 at 8:20 AM, Albert ARIBAUD > wrote: > > board_init_f_mem() alters the C runtime environment's > > stack it ls actually already using. This is not a valid > > C runtime environment and may confli

Re: [U-Boot] [PATCH] Fix board init code to use a valid C runtime environment

2015-11-09 Thread Albert ARIBAUD
Hello Thomas, On Tue, 10 Nov 2015 09:14:01 +0800, Thomas Chou wrote: > Hi Albert, > > On 2015年11月10日 08:20, Albert ARIBAUD wrote: > > board_init_f_mem() alters the C runtime environment's > > stack it ls actually already using. This is not a valid > > C runtime environment and may conflict with

Re: [U-Boot] [PATCH] Fix board init code to use a valid C runtime environment

2015-11-09 Thread Bin Meng
Hi Albert, On Tue, Nov 10, 2015 at 8:20 AM, Albert ARIBAUD wrote: > board_init_f_mem() alters the C runtime environment's > stack it ls actually already using. This is not a valid > C runtime environment and may conflict with the C compiler's > expectations. What C compiler's expectations confli

Re: [U-Boot] [PATCH] Fix board init code to use a valid C runtime environment

2015-11-09 Thread Thomas Chou
Hi Albert, On 2015年11月10日 08:20, Albert ARIBAUD wrote: board_init_f_mem() alters the C runtime environment's stack it ls actually already using. This is not a valid C runtime environment and may conflict with the C compiler's expectations. Split board_init_f_mem into C functions which do not al

[U-Boot] [PATCH] Fix board init code to use a valid C runtime environment

2015-11-09 Thread Albert ARIBAUD
board_init_f_mem() alters the C runtime environment's stack it ls actually already using. This is not a valid C runtime environment and may conflict with the C compiler's expectations. Split board_init_f_mem into C functions which do not alter their own stack and therefore function in a valid C ru