Re: [U-Boot] [PATCH] LaCie kirkwood boards: allow disk > 2TB

2013-06-13 Thread Sascha Silbe
Frédéric Leroy writes: > I will convert every ide block number to 64 bit for disk and partitions. > I guess CONFIG_LBA48 is also broken in common/cmd_ide.c : FWIW, I have a patch pending for this already. But it's necessarily pretty invasive and I'm not even sure yet that I've found all places

Re: [U-Boot] [PATCH] LaCie kirkwood boards: allow disk > 2TB

2013-06-13 Thread Frédéric Leroy
Le 13/06/2013 15:21, Albert ARIBAUD a écrit : > > I guess CONFIG_LBA48 is also broken in common/cmd_ide.c : > > > > ulong ide_write(int device, ulong blknr, lbaint_t blkcnt, const void > > *buffer) > > { > > ulong n = 0; > > unsigned char c; > > > > #ifdef CONFIG_LBA48 > > unsigned c

Re: [U-Boot] [PATCH] LaCie kirkwood boards: allow disk > 2TB

2013-06-13 Thread Albert ARIBAUD
Hi Frédéric, On Thu, 13 Jun 2013 15:03:49 +0200, Frédéric Leroy wrote: > Le 13/06/2013 13:33, Albert ARIBAUD a écrit : > > With gcc version 4.7.2 (Ubuntu/Linaro 4.7.2-2ubuntu1) this patch causes > > the following warning for all boards: > > > > cmd_ide.c:992:4: warning: right shift count >= widt

Re: [U-Boot] [PATCH] LaCie kirkwood boards: allow disk > 2TB

2013-06-13 Thread Frédéric Leroy
Le 13/06/2013 13:33, Albert ARIBAUD a écrit : > With gcc version 4.7.2 (Ubuntu/Linaro 4.7.2-2ubuntu1) this patch causes > the following warning for all boards: > > cmd_ide.c:992:4: warning: right shift count >= width of type [enabled > by default] > > Amicalement, I will convert every ide block n

Re: [U-Boot] [PATCH] LaCie kirkwood boards: allow disk > 2TB

2013-06-13 Thread Albert ARIBAUD
Hi Frederic, On Mon, 10 Jun 2013 15:30:53 +0200, Frederic Leroy wrote: > From: Frédéric Leroy > > For big disk support, we need LBA addressing on 64 bits > --- > include/configs/lacie_kw.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/configs/lacie_kw.h b/include/configs/l

[U-Boot] [PATCH] LaCie kirkwood boards: allow disk > 2TB

2013-06-10 Thread Frederic Leroy
From: Frédéric Leroy For big disk support, we need LBA addressing on 64 bits --- include/configs/lacie_kw.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/configs/lacie_kw.h b/include/configs/lacie_kw.h index 09b5798..847afcd 100644 --- a/include/configs/lacie_kw.h +++ b/include/con

Re: [U-Boot] [PATCH] LaCie kirkwood boards: allow disk > 2TB

2013-06-10 Thread Frédéric Leroy
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 10/06/2013 15:44, Simon Guinot a écrit : > On Mon, Jun 10, 2013 at 03:30:53PM +0200, Frederic Leroy wrote: > > From: Frédéric Leroy > > > > For big disk support, we need LBA addressing on 64 bits > > --- > > include/configs/lacie_kw.h | 1 + > >

Re: [U-Boot] [PATCH] LaCie kirkwood boards: allow disk > 2TB

2013-06-10 Thread Albert ARIBAUD
Hi Simon, On Mon, 10 Jun 2013 16:29:26 +0200, Simon Guinot wrote: > On Mon, Jun 10, 2013 at 04:20:49PM +0200, Frédéric Leroy wrote: > > > > Le 10/06/2013 15:44, Simon Guinot a écrit : > > > On Mon, Jun 10, 2013 at 03:30:53PM +0200, Frederic Leroy wrote: > > > > From: Frédéric Leroy > > > > > >

Re: [U-Boot] [PATCH] LaCie kirkwood boards: allow disk > 2TB

2013-06-10 Thread Simon Guinot
On Mon, Jun 10, 2013 at 04:20:49PM +0200, Frédéric Leroy wrote: > > Le 10/06/2013 15:44, Simon Guinot a écrit : > > On Mon, Jun 10, 2013 at 03:30:53PM +0200, Frederic Leroy wrote: > > > From: Frédéric Leroy > > > > > > For big disk support, we need LBA addressing on 64 bits > > > --- > > > inclu

Re: [U-Boot] [PATCH] LaCie kirkwood boards: allow disk > 2TB

2013-06-10 Thread Simon Guinot
On Mon, Jun 10, 2013 at 03:30:53PM +0200, Frederic Leroy wrote: > From: Frédéric Leroy > > For big disk support, we need LBA addressing on 64 bits > --- > include/configs/lacie_kw.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/include/configs/lacie_kw.h b/include/configs/lacie_kw.h