[U-Boot] [PATCH] MIPS: Add board_early_init_f() to init_sequence

2008-11-12 Thread Stefan Roese
This patch adds the board_early_init_f() call to the MIPS init sequence. A weak dummy implementation is also added which can be overridden by a board specific version. This will be used by the upcoming VCTH board support. Signed-off-by: Stefan Roese <[EMAIL PROTECTED]> --- lib_mips/board.c | 1

Re: [U-Boot] [PATCH] MIPS: Add board_early_init_f() to init_sequence

2008-11-15 Thread Shinya Kuribayashi
Stefan Roese wrote: > This patch adds the board_early_init_f() call to the MIPS init > sequence. A weak dummy implementation is also added which can be > overridden by a board specific version. > > This will be used by the upcoming VCTH board support. > > Signed-off-by: Stefan Roese <[EMAIL PROTE

Re: [U-Boot] [PATCH] MIPS: Add board_early_init_f() to init_sequence

2008-11-17 Thread Stefan Roese
On Sunday 16 November 2008, Shinya Kuribayashi wrote: > > +int __board_early_init_f(void) > > +{ > > + /* > > +* Nothing to do in this dummy implementation > > +*/ > > + return 0; > > +} > > +int board_early_init_f(void) __attribute__((weak, > > alias("__board_early_init_f"))); + > > /

Re: [U-Boot] [PATCH] MIPS: Add board_early_init_f() to init_sequence

2008-11-17 Thread Jean-Christophe PLAGNIOL-VILLARD
On 13:18 Wed 12 Nov , Stefan Roese wrote: > This patch adds the board_early_init_f() call to the MIPS init > sequence. A weak dummy implementation is also added which can be > overridden by a board specific version. > > This will be used by the upcoming VCTH board support. > > Signed-off-by:

Re: [U-Boot] [PATCH] MIPS: Add board_early_init_f() to init_sequence

2008-11-17 Thread Shinya Kuribayashi
Stefan Roese wrote: >> This is ok. I don't know why people prefers alias, though :-) > > Just because we don't need the ugly #ifdef's by using weak aliases. It has > some drawbacks of course but in general the resulting source code > looks "cleaner". I was being vague. I prefers something lik

Re: [U-Boot] [PATCH] MIPS: Add board_early_init_f() to init_sequence

2008-11-18 Thread Shinya Kuribayashi
Jean-Christophe PLAGNIOL-VILLARD wrote: > On 13:18 Wed 12 Nov , Stefan Roese wrote: >> diff --git a/lib_mips/board.c b/lib_mips/board.c >> index 77e1cc8..01dda69 100644 >> --- a/lib_mips/board.c >> +++ b/lib_mips/board.c >> @@ -70,6 +70,15 @@ static ulong mem_malloc_brk; >> */ >> unsigned lo