Re: [U-Boot] [PATCH] Nand: Implement raw read/write and biterr

2009-10-19 Thread Scott Wood
On Wed, Sep 30, 2009 at 12:11:39PM -0600, John Rigby wrote: > +static int nand_rdwr_raw(int rdwr, nand_info_t *nand, ulong off, u_char *buf, > + size_t size) Offset should be loff_t, here and elsewhere. > +{ > + struct mtd_oob_ops ops = { > + .len = nan

Re: [U-Boot] [PATCH] Nand: Implement raw read/write and biterr

2009-10-19 Thread Scott Wood
On Wed, Sep 30, 2009 at 02:22:09PM -0500, Tom wrote: > John Rigby wrote: >> @@ -494,13 +600,16 @@ U_BOOT_CMD(nand, CONFIG_SYS_MAXARGS, 1, do_nand, >> "nand write - addr off|partition size\n" >> "read/write 'size' bytes starting at offset 'off'\n" >> "to/from memory address '

Re: [U-Boot] [PATCH] Nand: Implement raw read/write and biterr

2009-09-30 Thread John Rigby
Tom, Thanks for the comments. I'll wait a couple of days for others then resubmit with fixes for these problems and any others that come up. John On Wed, Sep 30, 2009 at 1:22 PM, Tom wrote: > John Rigby wrote: > >> New commands nand read.raw and write.raw read/write >> main and oob area. >> >

Re: [U-Boot] [PATCH] Nand: Implement raw read/write and biterr

2009-09-30 Thread Tom
John Rigby wrote: > New commands nand read.raw and write.raw read/write > main and oob area. > > Implement previously stubbed nand biterr command. > > Document the above and also the previously undocumented > read.oob and write.oob. > > Signed-off-by: John Rigby > --- > common/cmd_nand.c | 11

[U-Boot] [PATCH] Nand: Implement raw read/write and biterr

2009-09-30 Thread John Rigby
New commands nand read.raw and write.raw read/write main and oob area. Implement previously stubbed nand biterr command. Document the above and also the previously undocumented read.oob and write.oob. Signed-off-by: John Rigby --- common/cmd_nand.c | 115 ++