Re: [U-Boot] [PATCH] Revert "env: net: Move eth_parse_enetaddr() to net.c/h"

2019-09-16 Thread Simon Glass
Hi Ondřej, On Fri, 13 Sep 2019 at 14:11, Ondřej Jirman wrote: > > On Fri, Sep 13, 2019 at 08:00:50PM +, Joe Hershberger wrote: > > On Fri, Sep 13, 2019 at 2:53 PM Ondřej Jirman wrote: > > > > It sounds like your board / build config is not in the mainline tree, > > > > so there is no way Sim

Re: [U-Boot] [PATCH] Revert "env: net: Move eth_parse_enetaddr() to net.c/h"

2019-09-13 Thread Ondřej Jirman
On Fri, Sep 13, 2019 at 08:00:50PM +, Joe Hershberger wrote: > On Fri, Sep 13, 2019 at 2:53 PM Ondřej Jirman wrote: > > > It sounds like your board / build config is not in the mainline tree, > > > so there is no way Simon could have known it would break you, and it > > > didn't break the exis

Re: [U-Boot] [PATCH] Revert "env: net: Move eth_parse_enetaddr() to net.c/h"

2019-09-13 Thread Joe Hershberger
On Fri, Sep 13, 2019 at 2:53 PM Ondřej Jirman wrote: > > Hi Joe, > > On Fri, Sep 13, 2019 at 07:38:20PM +, Joe Hershberger wrote: > > Hi Ondřej, > > > > On Fri, Sep 13, 2019 at 2:12 PM Ondřej Jirman wrote: > > > > > > On Fri, Sep 13, 2019 at 10:58:14AM -0600, Simon Glass wrote: > > > > Hi, >

Re: [U-Boot] [PATCH] Revert "env: net: Move eth_parse_enetaddr() to net.c/h"

2019-09-13 Thread Ondřej Jirman
Hi Joe, On Fri, Sep 13, 2019 at 07:38:20PM +, Joe Hershberger wrote: > Hi Ondřej, > > On Fri, Sep 13, 2019 at 2:12 PM Ondřej Jirman wrote: > > > > On Fri, Sep 13, 2019 at 10:58:14AM -0600, Simon Glass wrote: > > > Hi, > > > > > > On Fri, 13 Sep 2019 at 08:07, Heinrich Schuchardt > > > wrot

Re: [U-Boot] [PATCH] Revert "env: net: Move eth_parse_enetaddr() to net.c/h"

2019-09-13 Thread Joe Hershberger
Hi Ondřej, On Fri, Sep 13, 2019 at 2:12 PM Ondřej Jirman wrote: > > On Fri, Sep 13, 2019 at 10:58:14AM -0600, Simon Glass wrote: > > Hi, > > > > On Fri, 13 Sep 2019 at 08:07, Heinrich Schuchardt > > wrote: > > > > > > On 9/13/19 1:48 PM, Ondřej Jirman wrote: > > > > On Fri, Sep 13, 2019 at 01:1

Re: [U-Boot] [PATCH] Revert "env: net: Move eth_parse_enetaddr() to net.c/h"

2019-09-13 Thread Ondřej Jirman
On Fri, Sep 13, 2019 at 10:58:14AM -0600, Simon Glass wrote: > Hi, > > On Fri, 13 Sep 2019 at 08:07, Heinrich Schuchardt wrote: > > > > On 9/13/19 1:48 PM, Ondřej Jirman wrote: > > > On Fri, Sep 13, 2019 at 01:19:18PM +0200, Heinrich Schuchardt wrote: > > >> On 9/13/19 1:48 AM, meg...@megous.com

Re: [U-Boot] [PATCH] Revert "env: net: Move eth_parse_enetaddr() to net.c/h"

2019-09-13 Thread Heinrich Schuchardt
On 9/13/19 6:58 PM, Simon Glass wrote: > Hi, > > On Fri, 13 Sep 2019 at 08:07, Heinrich Schuchardt wrote: >> >> On 9/13/19 1:48 PM, Ondřej Jirman wrote: >>> On Fri, Sep 13, 2019 at 01:19:18PM +0200, Heinrich Schuchardt wrote: On 9/13/19 1:48 AM, meg...@megous.com wrote: > From: Ondrej Jir

Re: [U-Boot] [PATCH] Revert "env: net: Move eth_parse_enetaddr() to net.c/h"

2019-09-13 Thread Simon Glass
Hi, On Fri, 13 Sep 2019 at 08:07, Heinrich Schuchardt wrote: > > On 9/13/19 1:48 PM, Ondřej Jirman wrote: > > On Fri, Sep 13, 2019 at 01:19:18PM +0200, Heinrich Schuchardt wrote: > >> On 9/13/19 1:48 AM, meg...@megous.com wrote: > >>> From: Ondrej Jirman > >>> > >>> The reverted patch causes lin

Re: [U-Boot] [PATCH] Revert "env: net: Move eth_parse_enetaddr() to net.c/h"

2019-09-13 Thread Heinrich Schuchardt
On 9/13/19 1:48 PM, Ondřej Jirman wrote: > On Fri, Sep 13, 2019 at 01:19:18PM +0200, Heinrich Schuchardt wrote: >> On 9/13/19 1:48 AM, meg...@megous.com wrote: >>> From: Ondrej Jirman >>> >>> The reverted patch causes linking error with disabled CONFIG_NET: >>> >>>cmd/built-in.o: In function `

Re: [U-Boot] [PATCH] Revert "env: net: Move eth_parse_enetaddr() to net.c/h"

2019-09-13 Thread Ondřej Jirman
On Fri, Sep 13, 2019 at 01:19:18PM +0200, Heinrich Schuchardt wrote: > On 9/13/19 1:48 AM, meg...@megous.com wrote: > > From: Ondrej Jirman > > > > The reverted patch causes linking error with disabled CONFIG_NET: > > > >cmd/built-in.o: In function `eth_env_get_enetaddr': > >u-boot-v2019

Re: [U-Boot] [PATCH] Revert "env: net: Move eth_parse_enetaddr() to net.c/h"

2019-09-13 Thread Heinrich Schuchardt
On 9/13/19 1:48 AM, meg...@megous.com wrote: From: Ondrej Jirman The reverted patch causes linking error with disabled CONFIG_NET: cmd/built-in.o: In function `eth_env_get_enetaddr': u-boot-v2019.10/cmd/nvedit.c:363: undefined reference to `eth_parse_enetaddr' Function setup_environment

[U-Boot] [PATCH] Revert "env: net: Move eth_parse_enetaddr() to net.c/h"

2019-09-12 Thread megous
From: Ondrej Jirman The reverted patch causes linking error with disabled CONFIG_NET: cmd/built-in.o: In function `eth_env_get_enetaddr': u-boot-v2019.10/cmd/nvedit.c:363: undefined reference to `eth_parse_enetaddr' Function setup_environment() in board/sunxi/board.c calls eth_env_set_eneta