Re: [U-Boot] [PATCH] SPI: added support for MX51 to mxc_spi

2010-03-24 Thread Stefano Babic
Liu Hui-R64343 wrote: Hi, Hi, static unsigned long spi_bases[] = { 0x43fa4000, 0x5001, 0x53f84000, }; Here hardcode the value in mx31, while in mx51 it use the macro. Which makes Code style not consistent. yes, agree, the driver already contains a lot of

Re: [U-Boot] [PATCH] SPI: added support for MX51 to mxc_spi

2010-03-23 Thread Liu Hui-R64343
Hi, -Original Message- From: u-boot-boun...@lists.denx.de [mailto:u-boot-boun...@lists.denx.de] On Behalf Of Stefano Babic Sent: 2010年3月17日 0:22 To: u-boot@lists.denx.de Subject: [U-Boot] [PATCH] SPI: added support for MX51 to mxc_spi This patch add support for MX51 processor

Re: [U-Boot] [PATCH] SPI: added support for MX51 to mxc_spi

2010-03-22 Thread Stefano Babic
Tom wrote: +#define MXC_CSPIRXDATA0x00 +#define MXC_CSPITXDATA0x04 +#define MXC_CSPICTRL0x08 +#define MXC_CSPIPERIOD_32KHZ(1 15) + Pulling these out and making them common may not be the best thing to do. Located here, it hides the #ifdef CONFIG_MX27 #elif

Re: [U-Boot] [PATCH] SPI: added support for MX51 to mxc_spi

2010-03-20 Thread Tom
Stefano Babic wrote: This patch add support for MX51 processor and supports transfer of multiple word in a single transation. Signed-off-by: Stefano Babic sba...@denx.de --- The patch adds support for the MX51 and wants to remove some limitation on the old driver. Actually, the buffer

[U-Boot] [PATCH] SPI: added support for MX51 to mxc_spi

2010-03-16 Thread Stefano Babic
This patch add support for MX51 processor and supports transfer of multiple word in a single transation. Signed-off-by: Stefano Babic sba...@denx.de --- The patch adds support for the MX51 and wants to remove some limitation on the old driver. Actually, the buffer passed to the transfer function