Re: [U-Boot] [PATCH] add initial support for bluegiga apx4devkit

2011-12-14 Thread Veli-Pekka Peltola
On 12/14/2011 05:04 PM, Stefano Babic wrote: +void imx_get_mac_from_fuse(char *mac) +{ +memset(mac, 0, 6); +} This is wrong, and surely you do not get the address from fuses. What is correct way to get ethernet mac from environment instead of fuses? FEC driver seems to call imx_get_mac_fr

Re: [U-Boot] [PATCH] add initial support for bluegiga apx4devkit

2011-12-14 Thread Stefano Babic
On 14/12/2011 15:27, Veli-Pekka Peltola wrote: > > But now I understand that our way is far away from optimal so this will > be reworked in v2. > In this way you can also profit of the work already done in the SPL code. >>> +void imx_get_mac_from_fuse(char *mac) >>> +{ >>> +memset(mac, 0, 6

Re: [U-Boot] [PATCH] add initial support for bluegiga apx4devkit

2011-12-14 Thread Veli-Pekka Peltola
Hi Stefano, Thanks for your review. Please see my comments below. On 12/14/2011 03:20 PM, Stefano Babic wrote: On 13/12/2011 15:54, Veli-Pekka Peltola wrote: Add initial support for Bluegiga APX4 CoM and development kit. Signed-off-by: Veli-Pekka Peltola Cc: Stefano Babic --- Hi Veli-Pekka,

Re: [U-Boot] [PATCH] add initial support for bluegiga apx4devkit

2011-12-14 Thread Stefano Babic
On 13/12/2011 15:54, Veli-Pekka Peltola wrote: > Add initial support for Bluegiga APX4 CoM and development kit. > > Signed-off-by: Veli-Pekka Peltola > Cc: Stefano Babic > --- Hi Veli-Pekka, > board/bluegiga/apx4devkit/Makefile | 45 +++ > board/bluegiga/apx4devkit/apx4devkit.c | 2

Re: [U-Boot] [PATCH] add initial support for bluegiga apx4devkit

2011-12-13 Thread Fabio Estevam
On Tue, Dec 13, 2011 at 12:54 PM, Veli-Pekka Peltola wrote: > Add initial support for Bluegiga APX4 CoM and development kit. > > Signed-off-by: Veli-Pekka Peltola > Cc: Stefano Babic I applied this patch on top of head U-boot and got build errors when building "make u-boot.sb". Can you please

[U-Boot] [PATCH] add initial support for bluegiga apx4devkit

2011-12-13 Thread Veli-Pekka Peltola
Add initial support for Bluegiga APX4 CoM and development kit. Signed-off-by: Veli-Pekka Peltola Cc: Stefano Babic --- board/bluegiga/apx4devkit/Makefile | 45 +++ board/bluegiga/apx4devkit/apx4devkit.c | 204 boards.cfg |