Re: [U-Boot] [PATCH] avr32: fix timer_init() return type

2011-11-29 Thread Andreas Bießmann
Dear Reinhard, Am 13.10.2011 12:27, schrieb Reinhard Meyer: > Dear Andreas Bießmann, >>> if (set_interrupt_handler(0, &timer_interrupt_handler, 3)) >>> - return; >>> + return 0; >> >> NAK, this is an error and should return a negative value (though the >> return value is cu

Re: [U-Boot] [PATCH] avr32: fix timer_init() return type

2011-10-13 Thread Mike Frysinger
On Thursday 13 October 2011 06:27:38 Reinhard Meyer wrote: > Dear Andreas Bießmann, > > BTW there is another patch pending -> > > http://patchwork.ozlabs.org/patch/117688/ > > I'll apply that one in the year 2015 ;) > > NO.. its on my list for applying into next WFM -mike signature.asc Descrip

Re: [U-Boot] [PATCH] avr32: fix timer_init() return type

2011-10-13 Thread Reinhard Meyer
Dear Andreas Bießmann, >> if (set_interrupt_handler(0, &timer_interrupt_handler, 3)) >> -return; >> +return 0; > > NAK, this is an error and should return a negative value (though the > return value is currently not evaluated). Agreed > > BTW there is another patch

Re: [U-Boot] [PATCH] avr32: fix timer_init() return type

2011-10-13 Thread Andreas Bießmann
Dear Mike, Am 13.10.2011 07:11, schrieb Mike Frysinger: > The common.h header says this has to return an int, otherwise we get > build failures due to mismatched prototype and function definition. > > Signed-off-by: Mike Frysinger > --- > arch/avr32/cpu/interrupts.c |6 -- > 1 files cha

[U-Boot] [PATCH] avr32: fix timer_init() return type

2011-10-12 Thread Mike Frysinger
The common.h header says this has to return an int, otherwise we get build failures due to mismatched prototype and function definition. Signed-off-by: Mike Frysinger --- arch/avr32/cpu/interrupts.c |6 -- 1 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/avr32/cpu/inte