Re: [U-Boot] [PATCH] biosemu: include asm/io.h header

2013-04-04 Thread Tom Rini
On Thu, Apr 04, 2013 at 07:59:35AM +0200, Linus Walleij wrote: On Thu, Apr 4, 2013 at 12:05 AM, Tom Rini tr...@ti.com wrote: On Wed, Apr 03, 2013 at 07:07:00PM +0200, Linus Walleij wrote: Yes the Integrator has PCI support since ages, and I do have a VGA card mounted in one of the slots

Re: [U-Boot] [PATCH] biosemu: include asm/io.h header

2013-04-03 Thread Tom Rini
On Tue, Apr 02, 2013 at 12:32:40PM +0200, Albert ARIBAUD wrote: Hi Linus, On Tue, 2 Apr 2013 12:09:21 +0200, Linus Walleij linus.wall...@linaro.org wrote: On Tue, Apr 2, 2013 at 10:56 AM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: NAK -- no ARM target needs bios emulation,

Re: [U-Boot] [PATCH] biosemu: include asm/io.h header

2013-04-03 Thread Linus Walleij
On Wed, Apr 3, 2013 at 6:02 PM, Tom Rini tr...@ti.com wrote: Grr, I missed this discussion, sorry. But I don't feel this falls into the no dead code rule, but does fall into the lets not make life too hard for others rule I have at least. There's at least one board in u-boot-arm now

Re: [U-Boot] [PATCH] biosemu: include asm/io.h header

2013-04-03 Thread Tom Rini
On Wed, Apr 03, 2013 at 07:07:00PM +0200, Linus Walleij wrote: On Wed, Apr 3, 2013 at 6:02 PM, Tom Rini tr...@ti.com wrote: Grr, I missed this discussion, sorry. But I don't feel this falls into the no dead code rule, but does fall into the lets not make life too hard for others rule I

Re: [U-Boot] [PATCH] biosemu: include asm/io.h header

2013-04-03 Thread Linus Walleij
On Thu, Apr 4, 2013 at 12:05 AM, Tom Rini tr...@ti.com wrote: On Wed, Apr 03, 2013 at 07:07:00PM +0200, Linus Walleij wrote: Yes the Integrator has PCI support since ages, and I do have a VGA card mounted in one of the slots ... the only issue is that I need biosemu to be working to

[U-Boot] [PATCH] biosemu: include asm/io.h header

2013-04-02 Thread Linus Walleij
This makes sure we have inline functions such as inb/outb that are used in these two files by including the arch-specific asm/io.h header. However the ARM version does not provide the accessors unless the config symbol __io is also defined so add that in front of the include. After this the bios

Re: [U-Boot] [PATCH] biosemu: include asm/io.h header

2013-04-02 Thread Albert ARIBAUD
Hi Linus, On Tue, 2 Apr 2013 10:14:14 +0200, Linus Walleij linus.wall...@linaro.org wrote: This makes sure we have inline functions such as inb/outb that are used in these two files by including the arch-specific asm/io.h header. However the ARM version does not provide the accessors unless

Re: [U-Boot] [PATCH] biosemu: include asm/io.h header

2013-04-02 Thread Linus Walleij
On Tue, Apr 2, 2013 at 10:56 AM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: NAK -- no ARM target needs bios emulation, so basing the #define on ARM requirements is incorrect. Actually, ARM targets build drivers/bios_emulator/libatibiosemu.o as the result of an overlook in ./Makefile

Re: [U-Boot] [PATCH] biosemu: include asm/io.h header

2013-04-02 Thread Albert ARIBAUD
Hi Linus, On Tue, 2 Apr 2013 12:09:21 +0200, Linus Walleij linus.wall...@linaro.org wrote: On Tue, Apr 2, 2013 at 10:56 AM, Albert ARIBAUD albert.u.b...@aribaud.net wrote: NAK -- no ARM target needs bios emulation, so basing the #define on ARM requirements is incorrect. Actually, ARM