Re: [U-Boot] [PATCH] board/bsc913x: Add config flag for bootdelay

2013-06-25 Thread Scott Wood
On 06/25/2013 07:38:20 AM, Rai Harninder-B01044 wrote: Hi Albert, (weird way of quoting messages; makes it really hard to see who said what. Can't your mail client use the standard ">" line prefix?) > Fixed No, it's not fixed. "> " is supposed to go before lines that you're quoting -- no

Re: [U-Boot] [PATCH] board/bsc913x: Add config flag for bootdelay

2013-06-25 Thread Rai Harninder-B01044
Hi Albert, (weird way of quoting messages; makes it really hard to see who said what. Can't your mail client use the standard ">" line prefix?) > Fixed As for the commit summary, it is fine by me. > Scott has commented on the same. Can you please have a look and suggest? Are you not mixing up

Re: [U-Boot] [PATCH] board/bsc913x: Add config flag for bootdelay

2013-06-24 Thread Scott Wood
On 06/24/2013 04:28:26 AM, Rai Harninder-B01044 wrote: Hello Albert, Plase fix commit message: you're not simply adding a boot delay flag, you're in fact disabling autoboot, which is quite different. [Rai Harninder-B01044] "Disable autoboot through bootdelay config flag". Is this ok? But

Re: [U-Boot] [PATCH] board/bsc913x: Add config flag for bootdelay

2013-06-24 Thread Rai Harninder-B01044
Hello Albert, Plase fix commit message: you're not simply adding a boot delay flag, you're in fact disabling autoboot, which is quite different. [Rai Harninder-B01044] "Disable autoboot through bootdelay config flag". Is this ok? Also, when touching on a board's code, you should Cc: the board'

Re: [U-Boot] [PATCH] board/bsc913x: Add config flag for bootdelay

2013-06-24 Thread Albert ARIBAUD
Hi Rai, On Mon, 24 Jun 2013 09:28:26 +, Rai Harninder-B01044 wrote: > Hello Albert, > > > Plase fix commit message: you're not simply adding a boot delay flag, you're > in fact disabling autoboot, which is quite different. > [Rai Harninder-B01044] "Disable autoboot through bootdelay confi

Re: [U-Boot] [PATCH] board/bsc913x: Add config flag for bootdelay

2013-06-23 Thread Albert ARIBAUD
Hi Harninder, On Mon, 17 Jun 2013 17:18:32 +0530, Harninder Rai wrote: > Keep the value of CONFIG_BOOTDELAY as -1 to disable autoboot > > Signed-off-by: Harninder Rai > --- > include/configs/BSC9131RDB.h |1 + > include/configs/BSC9132QDS.h |1 + > 2 files changed, 2 insertions(+), 0

[U-Boot] [PATCH] board/bsc913x: Add config flag for bootdelay

2013-06-17 Thread Harninder Rai
Keep the value of CONFIG_BOOTDELAY as -1 to disable autoboot Signed-off-by: Harninder Rai --- include/configs/BSC9131RDB.h |1 + include/configs/BSC9132QDS.h |1 + 2 files changed, 2 insertions(+), 0 deletions(-) diff --git a/include/configs/BSC9131RDB.h b/include/configs/BSC9131RDB.h i