Re: [U-Boot] [PATCH] board_f: explicitly disable console on early boot

2013-12-10 Thread Alexey Brodkin
On Thu, 2013-11-28 at 13:55 +0400, Alexey Brodkin wrote: On Wed, 2013-11-27 at 18:43 -0700, Simon Glass wrote: I have a similar patch locally, but it actually does memset() on the whole structure. Some archs handle this setup differently. For example both ARM and x86 now allocate it in

Re: [U-Boot] [PATCH] board_f: explicitly disable console on early boot

2013-12-10 Thread Simon Glass
On 10 December 2013 14:47, Alexey Brodkin alexey.brod...@synopsys.com wrote: On Thu, 2013-11-28 at 13:55 +0400, Alexey Brodkin wrote: On Wed, 2013-11-27 at 18:43 -0700, Simon Glass wrote: I have a similar patch locally, but it actually does memset() on the whole structure. Some archs

Re: [U-Boot] [PATCH] board_f: explicitly disable console on early boot

2013-11-28 Thread Alexey Brodkin
On Wed, 2013-11-27 at 18:43 -0700, Simon Glass wrote: I have a similar patch locally, but it actually does memset() on the whole structure. Some archs handle this setup differently. For example both ARM and x86 now allocate it in low level code so there is no need for the board_f code to

[U-Boot] [PATCH] board_f: explicitly disable console on early boot

2013-11-27 Thread Alexey Brodkin
If U-Boot build with DEBUG enabled/defined the first call of debug function (that dumps data to any available console) will happen before zeroing of initial gd in init call zero_global_data in init_sequence_f. And if stack was not filled with zeros chances are high that gd-have_console won't be

Re: [U-Boot] [PATCH] board_f: explicitly disable console on early boot

2013-11-27 Thread Simon Glass
On 27 November 2013 11:32, Alexey Brodkin alexey.brod...@synopsys.comwrote: If U-Boot build with DEBUG enabled/defined the first call of debug function (that dumps data to any available console) will happen before zeroing of initial gd in init call zero_global_data in init_sequence_f. And