Re: [U-Boot] [PATCH] clk: sifive: Fix ethernet regression on HiFive Unleashed

+devicetree On Wed, Sep 11, 2019 at 2:25 PM Anup Patel wrote: > > On Wed, Sep 11, 2019 at 7:28 AM Bin Meng wrote: > > > > Hi Marcus, > > > > On Tue, Sep 10, 2019 at 11:53 PM Marcus Comstedt wrote: > > > > > > > > > Hi Bin, > > > > > > Bin Meng writes: > > > > > > > So 4.14 definitely was an ou

Re: [U-Boot] [PATCH] clk: sifive: Fix ethernet regression on HiFive Unleashed

On Wed, Sep 11, 2019 at 7:28 AM Bin Meng wrote: > > Hi Marcus, > > On Tue, Sep 10, 2019 at 11:53 PM Marcus Comstedt wrote: > > > > > > Hi Bin, > > > > Bin Meng writes: > > > > > So 4.14 definitely was an out-of-tree kernel > > > > Everything before 5.2 was out-of-tree. > > > > > > > No one can g

Re: [U-Boot] [PATCH] clk: sifive: Fix ethernet regression on HiFive Unleashed

Hi Marcus, On Tue, Sep 10, 2019 at 11:53 PM Marcus Comstedt wrote: > > > Hi Bin, > > Bin Meng writes: > > > So 4.14 definitely was an out-of-tree kernel > > Everything before 5.2 was out-of-tree. > > > > No one can guarantee an out-of-tree implementation will be > > keeping compatible after it's

Re: [U-Boot] [PATCH] clk: sifive: Fix ethernet regression on HiFive Unleashed

Hi Bin, Bin Meng writes: > So 4.14 definitely was an out-of-tree kernel Everything before 5.2 was out-of-tree. > No one can guarantee an out-of-tree implementation will be > keeping compatible after it's accepted in-tree. Reviewers/maintainers can guarantee compatibility with existing hardw

Re: [U-Boot] [PATCH] clk: sifive: Fix ethernet regression on HiFive Unleashed

Hi Marcus, On Tue, Sep 10, 2019 at 4:52 AM Marcus Comstedt wrote: > > > Hi Bin, > > Bin Meng writes: > > >> Yes, but in which Linux? This whole thing started because U-Boot will > > > > The latest Linux kernel v5.3. > > Thanks. I'll try it later. As if to prove my point, the one from > 5.2.11

Re: [U-Boot] [PATCH] clk: sifive: Fix ethernet regression on HiFive Unleashed

Hi Bin, Bin Meng writes: >> Yes, but in which Linux? This whole thing started because U-Boot will > > The latest Linux kernel v5.3. Thanks. I'll try it later. As if to prove my point, the one from 5.2.11 (which is the Linux version I'm currently running) did not work (I got MMC but no ether

Re: [U-Boot] [PATCH] clk: sifive: Fix ethernet regression on HiFive Unleashed

Hi Marcus, On Sun, Sep 8, 2019 at 10:48 PM Marcus Comstedt wrote: > > > Hi Bin, > > Bin Meng writes: > > >> And which "Linux DTB" should that be? Since RISC-V seems to be going > > > > The one in arch/riscv/boot/dts/sifive. > > Yes, but in which Linux? This whole thing started because U-Boot w

Re: [U-Boot] [PATCH] clk: sifive: Fix ethernet regression on HiFive Unleashed

Hi Bin, Bin Meng writes: >> And which "Linux DTB" should that be? Since RISC-V seems to be going > > The one in arch/riscv/boot/dts/sifive. Yes, but in which Linux? This whole thing started because U-Boot will no longer accept the DTB used with Linux 4.14. If each Linux version is going to

Re: [U-Boot] [PATCH] clk: sifive: Fix ethernet regression on HiFive Unleashed

Hi Marcus, On Sun, Sep 8, 2019 at 9:19 PM Marcus Comstedt wrote: > > > Bin Meng writes: > > > OpenSBI v0.4 works fine if you supply the the Linux DTB via > > FW_PAYLOAD_FDT_PATH when building OpenSBI. > > And which "Linux DTB" should that be? Since RISC-V seems to be going The one in arch/risc

Re: [U-Boot] [PATCH] clk: sifive: Fix ethernet regression on HiFive Unleashed

Bin Meng writes: > OpenSBI v0.4 works fine if you supply the the Linux DTB via > FW_PAYLOAD_FDT_PATH when building OpenSBI. And which "Linux DTB" should that be? Since RISC-V seems to be going the same annoying way as ARM with a requirement that you switch DTB every time you switch kernel vers

Re: [U-Boot] [PATCH] clk: sifive: Fix ethernet regression on HiFive Unleashed

Hi Marcus, On Sun, Sep 8, 2019 at 8:54 PM Marcus Comstedt wrote: > > > Hi Bin, > > Bin Meng writes: > > > I believe the officially supported booting workflow is to use the > > latest DT from Linux and compile it into OpenSBI, then boot to U-Boot. > > The original DT shipped by FSBL is not used b

Re: [U-Boot] [PATCH] clk: sifive: Fix ethernet regression on HiFive Unleashed

Hi Bin, Bin Meng writes: > I believe the officially supported booting workflow is to use the > latest DT from Linux and compile it into OpenSBI, then boot to U-Boot. > The original DT shipped by FSBL is not used by OpenSBI or U-Boot. Ok, if U-Boot uses a DT compiled into OpenSBI then the incom

Re: [U-Boot] [PATCH] clk: sifive: Fix ethernet regression on HiFive Unleashed

Hi Marcus, On Sun, Sep 8, 2019 at 5:36 PM Marcus Comstedt wrote: > > Commit ed0ef37 broke compatibility with HiFive Unleashed with SiFive > FSBL 2018-03-20. This caused ethernet to stop working. Restore > compatibility by adding back the needed compatible string, and > removing the special hand

[U-Boot] [PATCH] clk: sifive: Fix ethernet regression on HiFive Unleashed

Commit ed0ef37 broke compatibility with HiFive Unleashed with SiFive FSBL 2018-03-20. This caused ethernet to stop working. Restore compatibility by adding back the needed compatible string, and removing the special handling of rtcclk which was dead code anyway since no __prci_clock actually name