Re: [U-Boot] [PATCH] cmd_fdt.c: fix parse of byte streams and strings

2009-09-11 Thread Scott Wood
On Thu, Sep 10, 2009 at 08:23:27PM -0400, Jerry Van Baren wrote: fdt set /ether...@f00 interrupts this is a string can now handle multiple strings (words) by concatenating them with spaces (quoted strings still work the same as before because of hush's argument parsing) fdt set

Re: [U-Boot] [PATCH] cmd_fdt.c: fix parse of byte streams and strings

2009-09-11 Thread Jerry Van Baren
Scott Wood wrote: On Thu, Sep 10, 2009 at 08:23:27PM -0400, Jerry Van Baren wrote: fdt set /ether...@f00 interrupts this is a string can now handle multiple strings (words) by concatenating them with spaces (quoted strings still work the same as before because of hush's argument parsing)

Re: [U-Boot] [PATCH] cmd_fdt.c: fix parse of byte streams and strings

2009-09-11 Thread Scott Wood
Jerry Van Baren wrote: Scott Wood wrote: On Thu, Sep 10, 2009 at 08:23:27PM -0400, Jerry Van Baren wrote: fdt set /ether...@f00 interrupts this is a string can now handle multiple strings (words) by concatenating them with spaces (quoted strings still work the same as before because of

Re: [U-Boot] [PATCH] cmd_fdt.c: fix parse of byte streams and strings

2009-09-11 Thread Andy Fleming
Strings are backwards compatible because the hush parser strips the quotes so all that that part of Ken's patch does is to extend it to paste together multiple arguments rather than limiting it to exactly one argument. The following also produces the original string: fdt set

Re: [U-Boot] [PATCH] cmd_fdt.c: fix parse of byte streams and strings

2009-09-11 Thread Jerry Van Baren
Andy Fleming wrote: Strings are backwards compatible because the hush parser strips the quotes so all that that part of Ken's patch does is to extend it to paste together multiple arguments rather than limiting it to exactly one argument. The following also produces the original string:

Re: [U-Boot] [PATCH] cmd_fdt.c: fix parse of byte streams and strings

2009-09-11 Thread Scott Wood
Ken MacLeod wrote: On Fri, Sep 11, 2009 at 11:30 AM, Jerry Van Baren gerald.vanba...@ge.com mailto:gerald.vanba...@ge.com wrote: Scott Wood wrote: On Thu, Sep 10, 2009 at 08:23:27PM -0400, Jerry Van Baren wrote: fdt set /ether...@f00 interrupts this is a string

Re: [U-Boot] [PATCH] cmd_fdt.c: fix parse of byte streams and strings

2009-09-11 Thread Ken MacLeod
On Fri, Sep 11, 2009 at 11:30 AM, Jerry Van Baren gerald.vanba...@ge.comwrote: Scott Wood wrote: On Thu, Sep 10, 2009 at 08:23:27PM -0400, Jerry Van Baren wrote: fdt set /ether...@f00 interrupts this is a string can now handle multiple strings (words) by concatenating them with spaces

Re: [U-Boot] [PATCH] cmd_fdt.c: fix parse of byte streams and strings

2009-09-11 Thread Jerry Van Baren
Ken MacLeod wrote: On Fri, Sep 11, 2009 at 11:30 AM, Jerry Van Baren gerald.vanba...@ge.com mailto:gerald.vanba...@ge.com wrote: Scott Wood wrote: On Thu, Sep 10, 2009 at 08:23:27PM -0400, Jerry Van Baren wrote: fdt set /ether...@f00 interrupts this is a string

[U-Boot] [PATCH] cmd_fdt.c: fix parse of byte streams and strings

2009-09-10 Thread Ken MacLeod
Commit 4abd844d8e extended the fdt command parser to handle property strings which are split across multiple arguments but it was broken for byte streams and strings. This patch fixes those. Signed-off-by: Ken MacLeod k...@bitsko.slc.ut.us --- common/cmd_fdt.c | 11 +-- 1 files

Re: [U-Boot] [PATCH] cmd_fdt.c: fix parse of byte streams and strings

2009-09-10 Thread Jerry Van Baren
Hi Ken, Ken MacLeod wrote: Commit 4abd844d8e extended the fdt command parser to handle property strings which are split across multiple arguments but it was broken for byte streams and strings. This patch fixes those. Signed-off-by: Ken MacLeod k...@bitsko.slc.ut.us Thanks for the patch.