Re: [U-Boot] [PATCH] cmd_mmc: add support device command for selecting mmc device

2009-04-16 Thread Andy Fleming
On Sat, Mar 28, 2009 at 12:04 AM, Minkyu Kang wrote: > This patch improves device command for selecting mmc device > > Signed-off-by: Minkyu Kang Rather than porting features from the generic mmc framework into the legacy system, I'd really prefer if the omap driver were ported to the generic mm

Re: [U-Boot] [PATCH] cmd_mmc: add support device command for selecting mmc device (resend)

2009-04-04 Thread Wolfgang Denk
Dear Minkyu Kang, In message <49d05ee7.9010...@samsung.com> you wrote: > This patch improves device command for selecting mmc device > > Signed-off-by: Minkyu Kang > --- > common/cmd_mmc.c | 61 + > 1 files changed, 56 insertions(+), 5 delet

[U-Boot] [PATCH] cmd_mmc: add support device command for selecting mmc device (resend)

2009-03-29 Thread Minkyu Kang
This patch improves device command for selecting mmc device Signed-off-by: Minkyu Kang --- common/cmd_mmc.c | 61 + 1 files changed, 56 insertions(+), 5 deletions(-) diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c index 16c919b..fb99899 100

Re: [U-Boot] [PATCH] cmd_mmc: add support device command for selecting mmc device

2009-03-28 Thread Mike Frysinger
On Saturday 28 March 2009 01:04:10 Minkyu Kang wrote: > + case 2: > + if (strncmp(argv[1], "init", 4) == 0) { > + } else if (strncmp(argv[1], "dev", 3) == 0) { why strncmp ? i dont think it makes sense to support "init", "init.moo" "initaksldfjaksldfjasdf" ... > +

Re: [U-Boot] [PATCH] cmd_mmc: add support device command for selecting mmc device

2009-03-28 Thread Dirk Behme
Minkyu Kang wrote: > This patch improves device command for selecting mmc device We should add Andy to CC, as it seems that he is the new MMC maintainer :) Andy: Would be quite nice if you could comment on Minkyu's changes. See [1], [2] and [3] for the history, too. Dirk [1] http://lists.denx.

[U-Boot] [PATCH] cmd_mmc: add support device command for selecting mmc device

2009-03-27 Thread Minkyu Kang
This patch improves device command for selecting mmc device Signed-off-by: Minkyu Kang --- common/cmd_mmc.c | 69 ++ 1 files changed, 64 insertions(+), 5 deletions(-) diff --git a/common/cmd_mmc.c b/common/cmd_mmc.c index 16c919b..2557892 10