Re: [U-Boot] [PATCH] config.mk: Add -Wundef to CFLAGS

2013-10-05 Thread Albert ARIBAUD
Hi Simon, On Thu, 3 Oct 2013 17:49:23 -0600, Simon Glass wrote: > Hi, > > > On Wed, Oct 2, 2013 at 1:27 PM, Albert ARIBAUD > wrote: > > > Hi Masahiro, > > > > On Wed, 21 Aug 2013 13:33:19 +0900, Masahiro Yamada > > wrote: > > > > > Hello, Albert and U-Boot developers. > > > > > > > > > The

Re: [U-Boot] [PATCH] config.mk: Add -Wundef to CFLAGS

2013-10-03 Thread Simon Glass
Hi, On Wed, Oct 2, 2013 at 1:27 PM, Albert ARIBAUD wrote: > Hi Masahiro, > > On Wed, 21 Aug 2013 13:33:19 +0900, Masahiro Yamada > wrote: > > > Hello, Albert and U-Boot developers. > > > > > > The current status of this patch is Changes Requested. > > > > I love -Wundef option to be in, but it

Re: [U-Boot] [PATCH] config.mk: Add -Wundef to CFLAGS

2013-10-02 Thread Albert ARIBAUD
Hi Masahiro, On Wed, 21 Aug 2013 13:33:19 +0900, Masahiro Yamada wrote: > Hello, Albert and U-Boot developers. > > > The current status of this patch is Changes Requested. > > I love -Wundef option to be in, but it looks like > difficult for me to post the version 2. > > > The first choice

Re: [U-Boot] [PATCH] config.mk: Add -Wundef to CFLAGS

2013-08-20 Thread Masahiro Yamada
Hello, Albert and U-Boot developers. The current status of this patch is Changes Requested. I love -Wundef option to be in, but it looks like difficult for me to post the version 2. The first choice to meet Albert's requirement is > Therefore I ask: > > - that this patch be submitted along f

Re: [U-Boot] [PATCH] config.mk: Add -Wundef to CFLAGS

2013-07-31 Thread Albert ARIBAUD
Hi Masahiro, On Wed, 31 Jul 2013 11:45:18 +0900, Masahiro Yamada wrote: > Hello Albert > > > Will the patch cause some targets to break? > > I don't think so > because -Wundef option just prints warnings. > > > GCC manual says: > -Wundef > Warn if an undefined identifier is evaluated in an

Re: [U-Boot] [PATCH] config.mk: Add -Wundef to CFLAGS

2013-07-30 Thread Masahiro Yamada
Hello Albert > Will the patch cause some targets to break? I don't think so because -Wundef option just prints warnings. GCC manual says: -Wundef Warn if an undefined identifier is evaluated in an ‘#if’ directive. After applying this patch, I noticed warnings like follows: include/common.h

Re: [U-Boot] [PATCH] config.mk: Add -Wundef to CFLAGS

2013-07-30 Thread Albert ARIBAUD
Hi Masahiro, On Tue, 30 Jul 2013 11:57:05 +0900, Masahiro Yamada wrote: > In U-boot source, some '#if' directives evaluate > undefined identifiers. > > To find and fix them, this commit adds -Wundef to CFLAGS. > > Signed-off-by: Masahiro Yamada > --- > config.mk | 2 +- > 1 file changed, 1 i

[U-Boot] [PATCH] config.mk: Add -Wundef to CFLAGS

2013-07-29 Thread Masahiro Yamada
In U-boot source, some '#if' directives evaluate undefined identifiers. To find and fix them, this commit adds -Wundef to CFLAGS. Signed-off-by: Masahiro Yamada --- config.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config.mk b/config.mk index f71e145..7a92ae3 100644