Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Marek Vasut
On 5/31/19 3:31 PM, Tom Rini wrote: > On Fri, May 31, 2019 at 03:22:05PM +0200, Marek Vasut wrote: >> On 5/31/19 3:08 PM, Tom Rini wrote: >>> On Fri, May 31, 2019 at 02:57:08PM +0200, Marek Vasut wrote: On 5/31/19 2:51 PM, Tom Rini wrote: > On Fri, May 31, 2019 at 02:46:45PM +0200, Marek V

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Tom Rini
On Fri, May 31, 2019 at 03:22:05PM +0200, Marek Vasut wrote: > On 5/31/19 3:08 PM, Tom Rini wrote: > > On Fri, May 31, 2019 at 02:57:08PM +0200, Marek Vasut wrote: > >> On 5/31/19 2:51 PM, Tom Rini wrote: > >>> On Fri, May 31, 2019 at 02:46:45PM +0200, Marek Vasut wrote: > On 5/31/19 2:42 PM,

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Marek Vasut
On 5/31/19 3:08 PM, Tom Rini wrote: > On Fri, May 31, 2019 at 02:57:08PM +0200, Marek Vasut wrote: >> On 5/31/19 2:51 PM, Tom Rini wrote: >>> On Fri, May 31, 2019 at 02:46:45PM +0200, Marek Vasut wrote: On 5/31/19 2:42 PM, Tom Rini wrote: > On Fri, May 31, 2019 at 02:20:15PM +0200, Marek V

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Tom Rini
On Fri, May 31, 2019 at 02:58:47PM +0200, Marek Vasut wrote: > On 5/31/19 2:51 PM, Fabio Estevam wrote: > > On Fri, May 31, 2019 at 9:45 AM Marek Vasut wrote: > > > >> It's an accident just waiting to happen -- only a matter of time until > >> someone writes too large u-boot-dtb.img and silently

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Tom Rini
On Fri, May 31, 2019 at 02:57:08PM +0200, Marek Vasut wrote: > On 5/31/19 2:51 PM, Tom Rini wrote: > > On Fri, May 31, 2019 at 02:46:45PM +0200, Marek Vasut wrote: > >> On 5/31/19 2:42 PM, Tom Rini wrote: > >>> On Fri, May 31, 2019 at 02:20:15PM +0200, Marek Vasut wrote: > On 5/31/19 2:18 PM,

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Marek Vasut
On 5/31/19 2:51 PM, Fabio Estevam wrote: > On Fri, May 31, 2019 at 9:45 AM Marek Vasut wrote: > >> It's an accident just waiting to happen -- only a matter of time until >> someone writes too large u-boot-dtb.img and silently corrupts the file >> system right behind it ;-) > > If u-boot-dtb.img

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Marek Vasut
On 5/31/19 2:51 PM, Tom Rini wrote: > On Fri, May 31, 2019 at 02:46:45PM +0200, Marek Vasut wrote: >> On 5/31/19 2:42 PM, Tom Rini wrote: >>> On Fri, May 31, 2019 at 02:20:15PM +0200, Marek Vasut wrote: On 5/31/19 2:18 PM, Fabio Estevam wrote: > On Fri, May 31, 2019 at 9:17 AM Marek Vasut

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Tom Rini
On Fri, May 31, 2019 at 02:46:45PM +0200, Marek Vasut wrote: > On 5/31/19 2:42 PM, Tom Rini wrote: > > On Fri, May 31, 2019 at 02:20:15PM +0200, Marek Vasut wrote: > >> On 5/31/19 2:18 PM, Fabio Estevam wrote: > >>> On Fri, May 31, 2019 at 9:17 AM Marek Vasut wrote: > >>> > So I will have to

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Fabio Estevam
On Fri, May 31, 2019 at 9:45 AM Marek Vasut wrote: > It's an accident just waiting to happen -- only a matter of time until > someone writes too large u-boot-dtb.img and silently corrupts the file > system right behind it ;-) If u-boot-dtb.img grows it will corrupt the env region. We can detect

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Marek Vasut
On 5/31/19 2:42 PM, Tom Rini wrote: > On Fri, May 31, 2019 at 02:20:15PM +0200, Marek Vasut wrote: >> On 5/31/19 2:18 PM, Fabio Estevam wrote: >>> On Fri, May 31, 2019 at 9:17 AM Marek Vasut wrote: >>> So I will have to track a downstream patch for wandboard now ? >>> >>> I didn't mention we

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Marek Vasut
On 5/31/19 2:43 PM, Fabio Estevam wrote: > On Fri, May 31, 2019 at 9:20 AM Marek Vasut wrote: > >> How does the sabresd boot ? > > It boots from SD card with SPL at 1kB and u-boot-dtb.img at 69kB. > > We don't need EXT4 in SPL at all. It's an accident just waiting to happen -- only a matter of

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Fabio Estevam
On Fri, May 31, 2019 at 9:20 AM Marek Vasut wrote: > How does the sabresd boot ? It boots from SD card with SPL at 1kB and u-boot-dtb.img at 69kB. We don't need EXT4 in SPL at all. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/lis

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Tom Rini
On Fri, May 31, 2019 at 02:20:15PM +0200, Marek Vasut wrote: > On 5/31/19 2:18 PM, Fabio Estevam wrote: > > On Fri, May 31, 2019 at 9:17 AM Marek Vasut wrote: > > > >> So I will have to track a downstream patch for wandboard now ? > > > > I didn't mention we want to remove CONFIG_SPL_FS_EXT4 fro

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Ezequiel Garcia
On Fri, 2019-05-31 at 12:39 +0200, Stefano Babic wrote: > Hi Ezequiel, > > On 26/05/19 00:57, Marek Vasut wrote: > > On 5/26/19 12:45 AM, Ezequiel Garcia wrote: > > > On Sun, 2019-05-26 at 00:24 +0200, Marek Vasut wrote: > > > > On 5/25/19 11:47 PM, Ezequiel Garcia wrote: > > > > > On Sat, 2019-05

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Marek Vasut
On 5/31/19 2:18 PM, Fabio Estevam wrote: > On Fri, May 31, 2019 at 9:17 AM Marek Vasut wrote: > >> So I will have to track a downstream patch for wandboard now ? > > I didn't mention we want to remove CONFIG_SPL_FS_EXT4 from Wandboard. Ah OK, good, thanks. > I do want to remove it from mx6sabr

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Fabio Estevam
On Fri, May 31, 2019 at 9:17 AM Marek Vasut wrote: > So I will have to track a downstream patch for wandboard now ? I didn't mention we want to remove CONFIG_SPL_FS_EXT4 from Wandboard. I do want to remove it from mx6sabresd for sure. ___ U-Boot maili

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Marek Vasut
On 5/31/19 12:42 PM, Fabio Estevam wrote: > Hi Stefano, > > On Fri, May 31, 2019 at 7:39 AM Stefano Babic wrote: > >> They *could* be good reasons, but it depends on the use case. In case of >> Novena as Marek stated, it boots from filesystem and dropping this >> feature breaks definetly the boa

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Fabio Estevam
Hi Stefano, On Fri, May 31, 2019 at 7:39 AM Stefano Babic wrote: > They *could* be good reasons, but it depends on the use case. In case of > Novena as Marek stated, it boots from filesystem and dropping this > feature breaks definetly the board. > > My position is that each board maintainer can

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-31 Thread Stefano Babic
Hi Ezequiel, On 26/05/19 00:57, Marek Vasut wrote: > On 5/26/19 12:45 AM, Ezequiel Garcia wrote: >> On Sun, 2019-05-26 at 00:24 +0200, Marek Vasut wrote: >>> On 5/25/19 11:47 PM, Ezequiel Garcia wrote: On Sat, 2019-05-25 at 22:15 +0200, Marek Vasut wrote: > On 5/25/19 6:49 PM, Ezequiel Ga

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-26 Thread Marek Vasut
On 5/27/19 4:59 AM, Ezequiel Garcia wrote: [...] >>> I don't want to get into the DM discussion, the intention of this patch was >>> to reduce SPL size, not make room for a future increase. >> >> SPL size should not be reduced at the expense of useful functionality >> though. >> >>> That said, I a

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-26 Thread Ezequiel Garcia
On Sun, 26 May 2019 at 14:30, Marek Vasut wrote: > > On 5/26/19 6:18 PM, Ezequiel Garcia wrote: > > On Sun, 26 May 2019 at 12:05, Lukasz Majewski wrote: > >> > >> Hi Tom, > >> > >>> On Sun, May 26, 2019 at 01:46:53PM +0200, Lukasz Majewski wrote: > Hi Tom, > > > On Sun, May 26, 2019

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-26 Thread Marek Vasut
On 5/26/19 6:18 PM, Ezequiel Garcia wrote: > On Sun, 26 May 2019 at 12:05, Lukasz Majewski wrote: >> >> Hi Tom, >> >>> On Sun, May 26, 2019 at 01:46:53PM +0200, Lukasz Majewski wrote: Hi Tom, > On Sun, May 26, 2019 at 10:22:00AM +0200, Lukasz Majewski wrote: >> Dear Marek, Tom, >

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-26 Thread Ezequiel Garcia
On Sun, 26 May 2019 at 12:05, Lukasz Majewski wrote: > > Hi Tom, > > > On Sun, May 26, 2019 at 01:46:53PM +0200, Lukasz Majewski wrote: > > > Hi Tom, > > > > > > > On Sun, May 26, 2019 at 10:22:00AM +0200, Lukasz Majewski wrote: > > > > > Dear Marek, Tom, > > > > > > > > > > > On 5/26/19 1:23 AM,

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-26 Thread Lukasz Majewski
Hi Tom, > On Sun, May 26, 2019 at 01:46:53PM +0200, Lukasz Majewski wrote: > > Hi Tom, > > > > > On Sun, May 26, 2019 at 10:22:00AM +0200, Lukasz Majewski wrote: > > > > Dear Marek, Tom, > > > > > > > > > On 5/26/19 1:23 AM, Tom Rini wrote: > > > > > > On Sun, May 26, 2019 at 01:20:3

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-26 Thread Tom Rini
On Sun, May 26, 2019 at 01:46:53PM +0200, Lukasz Majewski wrote: > Hi Tom, > > > On Sun, May 26, 2019 at 10:22:00AM +0200, Lukasz Majewski wrote: > > > Dear Marek, Tom, > > > > > > > On 5/26/19 1:23 AM, Tom Rini wrote: > > > > > On Sun, May 26, 2019 at 01:20:34AM +0200, Marek Vasut wrote:

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-26 Thread Marek Vasut
On 5/26/19 1:46 PM, Lukasz Majewski wrote: > Hi Tom, > >> On Sun, May 26, 2019 at 10:22:00AM +0200, Lukasz Majewski wrote: >>> Dear Marek, Tom, >>> On 5/26/19 1:23 AM, Tom Rini wrote: > On Sun, May 26, 2019 at 01:20:34AM +0200, Marek Vasut wrote: >> On 5/26/19 1:08 AM, Tom Ri

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-26 Thread Lukasz Majewski
Hi Tom, > On Sun, May 26, 2019 at 10:22:00AM +0200, Lukasz Majewski wrote: > > Dear Marek, Tom, > > > > > On 5/26/19 1:23 AM, Tom Rini wrote: > > > > On Sun, May 26, 2019 at 01:20:34AM +0200, Marek Vasut wrote: > > > >> On 5/26/19 1:08 AM, Tom Rini wrote: > > > >>> On Sun, May 26, 201

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-26 Thread Tom Rini
On Sun, May 26, 2019 at 10:22:00AM +0200, Lukasz Majewski wrote: > Dear Marek, Tom, > > > On 5/26/19 1:23 AM, Tom Rini wrote: > > > On Sun, May 26, 2019 at 01:20:34AM +0200, Marek Vasut wrote: > > >> On 5/26/19 1:08 AM, Tom Rini wrote: > > >>> On Sun, May 26, 2019 at 12:57:08AM +0200, Marek Va

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-26 Thread Lukasz Majewski
Dear Marek, Tom, > On 5/26/19 1:23 AM, Tom Rini wrote: > > On Sun, May 26, 2019 at 01:20:34AM +0200, Marek Vasut wrote: > >> On 5/26/19 1:08 AM, Tom Rini wrote: > >>> On Sun, May 26, 2019 at 12:57:08AM +0200, Marek Vasut wrote: > On 5/26/19 12:45 AM, Ezequiel Garcia wrote: > > On

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-25 Thread Marek Vasut
On 5/26/19 2:33 AM, Tom Rini wrote: > On Sun, May 26, 2019 at 01:30:01AM +0200, Marek Vasut wrote: >> On 5/26/19 1:23 AM, Tom Rini wrote: >>> On Sun, May 26, 2019 at 01:20:34AM +0200, Marek Vasut wrote: On 5/26/19 1:08 AM, Tom Rini wrote: > On Sun, May 26, 2019 at 12:57:08AM +0200, Marek V

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-25 Thread Tom Rini
On Sun, May 26, 2019 at 01:30:01AM +0200, Marek Vasut wrote: > On 5/26/19 1:23 AM, Tom Rini wrote: > > On Sun, May 26, 2019 at 01:20:34AM +0200, Marek Vasut wrote: > >> On 5/26/19 1:08 AM, Tom Rini wrote: > >>> On Sun, May 26, 2019 at 12:57:08AM +0200, Marek Vasut wrote: > On 5/26/19 12:45 AM,

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-25 Thread Marek Vasut
On 5/26/19 1:23 AM, Tom Rini wrote: > On Sun, May 26, 2019 at 01:20:34AM +0200, Marek Vasut wrote: >> On 5/26/19 1:08 AM, Tom Rini wrote: >>> On Sun, May 26, 2019 at 12:57:08AM +0200, Marek Vasut wrote: On 5/26/19 12:45 AM, Ezequiel Garcia wrote: > On Sun, 2019-05-26 at 00:24 +0200, Marek

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-25 Thread Tom Rini
On Sun, May 26, 2019 at 01:20:34AM +0200, Marek Vasut wrote: > On 5/26/19 1:08 AM, Tom Rini wrote: > > On Sun, May 26, 2019 at 12:57:08AM +0200, Marek Vasut wrote: > >> On 5/26/19 12:45 AM, Ezequiel Garcia wrote: > >>> On Sun, 2019-05-26 at 00:24 +0200, Marek Vasut wrote: > On 5/25/19 11:47 PM

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-25 Thread Marek Vasut
On 5/26/19 1:08 AM, Tom Rini wrote: > On Sun, May 26, 2019 at 12:57:08AM +0200, Marek Vasut wrote: >> On 5/26/19 12:45 AM, Ezequiel Garcia wrote: >>> On Sun, 2019-05-26 at 00:24 +0200, Marek Vasut wrote: On 5/25/19 11:47 PM, Ezequiel Garcia wrote: > On Sat, 2019-05-25 at 22:15 +0200, Marek

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-25 Thread Tom Rini
On Sun, May 26, 2019 at 12:57:08AM +0200, Marek Vasut wrote: > On 5/26/19 12:45 AM, Ezequiel Garcia wrote: > > On Sun, 2019-05-26 at 00:24 +0200, Marek Vasut wrote: > >> On 5/25/19 11:47 PM, Ezequiel Garcia wrote: > >>> On Sat, 2019-05-25 at 22:15 +0200, Marek Vasut wrote: > On 5/25/19 6:49 PM

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-25 Thread Marek Vasut
On 5/26/19 12:45 AM, Ezequiel Garcia wrote: > On Sun, 2019-05-26 at 00:24 +0200, Marek Vasut wrote: >> On 5/25/19 11:47 PM, Ezequiel Garcia wrote: >>> On Sat, 2019-05-25 at 22:15 +0200, Marek Vasut wrote: On 5/25/19 6:49 PM, Ezequiel Garcia wrote: > i.MX6 platforms boot U-Boot second-stage

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-25 Thread Ezequiel Garcia
On Sun, 2019-05-26 at 00:24 +0200, Marek Vasut wrote: > On 5/25/19 11:47 PM, Ezequiel Garcia wrote: > > On Sat, 2019-05-25 at 22:15 +0200, Marek Vasut wrote: > > > On 5/25/19 6:49 PM, Ezequiel Garcia wrote: > > > > i.MX6 platforms boot U-Boot second-stage from unformatted space, > > > > and should

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-25 Thread Marek Vasut
On 5/25/19 11:47 PM, Ezequiel Garcia wrote: > On Sat, 2019-05-25 at 22:15 +0200, Marek Vasut wrote: >> On 5/25/19 6:49 PM, Ezequiel Garcia wrote: >>> i.MX6 platforms boot U-Boot second-stage from unformatted space, >>> and should not need Ext filesystem support on SPL. >>> >>> The commit was genera

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-25 Thread Ezequiel Garcia
On Sat, 2019-05-25 at 22:15 +0200, Marek Vasut wrote: > On 5/25/19 6:49 PM, Ezequiel Garcia wrote: > > i.MX6 platforms boot U-Boot second-stage from unformatted space, > > and should not need Ext filesystem support on SPL. > > > > The commit was generated with: > > > > git grep -l MX6 -- configs/

Re: [U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-25 Thread Marek Vasut
On 5/25/19 6:49 PM, Ezequiel Garcia wrote: > i.MX6 platforms boot U-Boot second-stage from unformatted space, > and should not need Ext filesystem support on SPL. > > The commit was generated with: > > git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e > '/CONFIG_SPL_FS_EX

[U-Boot] [PATCH] configs: Remove CONFIG_SPL_FS_EXT4 for all MX6 platforms

2019-05-25 Thread Ezequiel Garcia
i.MX6 platforms boot U-Boot second-stage from unformatted space, and should not need Ext filesystem support on SPL. The commit was generated with: git grep -l MX6 -- configs/ | xargs grep -l SPL_FS_EXT4 | xargs sed -i -e '/CONFIG_SPL_FS_EXT4=y/d' This change has a dramatic impact on SPL size: