Re: [U-Boot] [PATCH] env: Allow accessing non-mtd devices

2013-02-07 Thread Wolfgang Denk
Dear Lubomir, In message <1360244552.29426.9.camel@hobbes> you wrote: > > > You should define something like MTD_NO_FLASH or so, and use that. > > I found it a bit more abusive to use a MTD_* macro in mtd_type variable > for something what is not actually a type of a MTD device, specially > when

Re: [U-Boot] [PATCH] env: Allow accessing non-mtd devices

2013-02-07 Thread Lubomir Rintel
On Thu, 2013-02-07 at 00:21 +0100, Wolfgang Denk wrote: > Dear Lubomir Rintel, > > In message <1360191866.3594.10.camel@unicorn> you wrote: > > > > > > - if (mtd_type != MTD_DATAFLASH) > > > > + if (mtd_type && mtd_type != MTD_DATAFLASH) > > > > > > This change appears

Re: [U-Boot] [PATCH] env: Allow accessing non-mtd devices

2013-02-06 Thread Wolfgang Denk
Dear Lubomir Rintel, In message <1360191923-4688-1-git-send-email-lkund...@v3.sk> you wrote: > In certain cases, memory device is present as flat file or block device (via > mmc or mtdblock layer). Do not attempt MTD operations against it. > > Signed-off-by: Lubomir Rintel > --- > tools/env/fw_

Re: [U-Boot] [PATCH] env: Allow accessing non-mtd devices

2013-02-06 Thread Wolfgang Denk
Dear Lubomir Rintel, In message <1360191866.3594.10.camel@unicorn> you wrote: > > > > - if (mtd_type != MTD_DATAFLASH) > > > + if (mtd_type && mtd_type != MTD_DATAFLASH) > > > > This change appears to be redundant. If mtd_type is null, then this > > is already caught iun te test

[U-Boot] [PATCH] env: Allow accessing non-mtd devices

2013-02-06 Thread Lubomir Rintel
In certain cases, memory device is present as flat file or block device (via mmc or mtdblock layer). Do not attempt MTD operations against it. Signed-off-by: Lubomir Rintel --- tools/env/fw_env.c | 20 tools/env/fw_env.config |3 +++ 2 files changed, 19 insertions

Re: [U-Boot] [PATCH] env: Allow accessing non-mtd devices

2013-02-06 Thread Lubomir Rintel
On Thu, 2013-01-31 at 15:10 +0100, Wolfgang Denk wrote: > Dear Lubomir Rintel, > > In message <1359630144.16475.6.camel@hobbes> you wrote: > > > > Mine is a Kobo Mini e-book reader, which is basically Freescale MX50 > > with the only storage there being an MMC/SD card (removable from a slot > > if

Re: [U-Boot] [PATCH] env: Allow accessing non-mtd devices

2013-01-31 Thread Wolfgang Denk
Dear Lubomir Rintel, In message <1359630144.16475.6.camel@hobbes> you wrote: > > Mine is a Kobo Mini e-book reader, which is basically Freescale MX50 > with the only storage there being an MMC/SD card (removable from a slot > if disassembled), which contains uboot and its environment as well as >

Re: [U-Boot] [PATCH] env: Allow accessing non-mtd devices

2013-01-31 Thread Lubomir Rintel
On Thu, 2013-01-31 at 07:48 +0100, Wolfgang Denk wrote: > Dear Lubomir Rintel, > > In message <1359589584-19846-1-git-send-email-lkund...@v3.sk> you wrote: > > In certain cases, memory device is present as flat file or block device (via > > mmc or mtdblock layer). Do not attempt MTD operations aga

Re: [U-Boot] [PATCH] env: Allow accessing non-mtd devices

2013-01-30 Thread Wolfgang Denk
Dear Lubomir Rintel, In message <1359589584-19846-1-git-send-email-lkund...@v3.sk> you wrote: > In certain cases, memory device is present as flat file or block device (via > mmc or mtdblock layer). Do not attempt MTD operations against it. What exactly would be such cases? > diff --git a/tools/

[U-Boot] [PATCH] env: Allow accessing non-mtd devices

2013-01-30 Thread Lubomir Rintel
In certain cases, memory device is present as flat file or block device (via mmc or mtdblock layer). Do not attempt MTD operations against it. --- tools/env/fw_env.c | 21 - tools/env/fw_env.config |3 +++ 2 files changed, 19 insertions(+), 5 deletions(-) diff --git