Re: [U-Boot] [PATCH] env_mmc: fix compile warning

2010-11-14 Thread Wolfgang Denk
Dear Lei Wen, In message aanlkti=i3yuigutwhy6peyiwah71ljuvokyxu7e4w...@mail.gmail.com you wrote: --00248c0d766c2c192a0494a740ed Content-Type: text/plain; charset=UTF-8 Hi Mike, Please review this refined patch. From a7c694f84bec6b0db26ece4c77d06585be5a6755 Mon Sep 17 00:00:00 2001

Re: [U-Boot] [PATCH] env_mmc: fix compile warning

2010-11-09 Thread Mike Frysinger
On Monday, November 08, 2010 01:59:48 Lei Wen wrote: Signed-off-by: Lei Wen lei...@marvell.com --- common/env_mmc.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/common/env_mmc.c b/common/env_mmc.c index 3d7fceb..7c9392c 100644 --- a/common/env_mmc.c +++

Re: [U-Boot] [PATCH] env_mmc: fix compile warning

2010-11-09 Thread Mike Frysinger
On Tuesday, November 09, 2010 10:18:42 Lei Wen wrote: Hi Mike, please dont top post I am sorry for that... Here is the warning: env_mmc.c: In function 'saveenv': env_mmc.c:109: warning: implicit declaration of function 'hexport' please resend your patch with an updated changelog -mike

Re: [U-Boot] [PATCH] env_mmc: fix compile warning

2010-11-09 Thread Lei Wen
Hi Mike, Please review this refined patch. From a7c694f84bec6b0db26ece4c77d06585be5a6755 Mon Sep 17 00:00:00 2001 From: Lei Wen lei...@marvell.com Date: Wed, 10 Nov 2010 07:44:03 +0800 Subject: [PATCH] env_mmc: fix compile warning hexport would complain implicit declaration, if we don't add the

Re: [U-Boot] [PATCH] env_mmc: fix compile warning

2010-11-09 Thread Mike Frysinger
On Tuesday, November 09, 2010 18:39:23 Lei Wen wrote: Hi Mike, Please review this refined patch. thanks, this looks much better not that ive ever used env_mmc, so i cant comment on correctness of it -mike signature.asc Description: This is a digitally signed message part.

[U-Boot] [PATCH] env_mmc: fix compile warning

2010-11-07 Thread Lei Wen
Signed-off-by: Lei Wen lei...@marvell.com --- common/env_mmc.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/common/env_mmc.c b/common/env_mmc.c index 3d7fceb..7c9392c 100644 --- a/common/env_mmc.c +++ b/common/env_mmc.c @@ -29,6 +29,7 @@ #include linux/stddef.h