Re: [U-Boot] [PATCH] fs: btrfs: Fix tree traversal with btrfs_next_slot()

2018-10-08 Thread Tom Rini
On Tue, Oct 02, 2018 at 01:22:28PM +0200, Marek Behún wrote: > Tested-by: Marek Behún > > Hello Tom, could you please apply the patch by Yevgeny? Sorry, I'll just lament that patchwork no longer has the ability to list unassigned patches anymore. I've given this to myself in patchwork and will

Re: [U-Boot] [PATCH] fs: btrfs: Fix tree traversal with btrfs_next_slot()

2018-10-02 Thread Marek Behún
Tested-by: Marek Behún Hello Tom, could you please apply the patch by Yevgeny? Marek On Fri, 7 Sep 2018 12:59:30 +0300 Yevgeny Popovych wrote: > When traversing slots in a btree (via btrfs_path) with > btrfs_next_slot(), we didn't correctly identify that the last slot in > the leaf was reach

Re: [U-Boot] [PATCH] fs: btrfs: Fix tree traversal with btrfs_next_slot()

2018-10-01 Thread Yevgeny Popovych
Hi Marek, No hurry from my side, please take your time! I think that might be the case for every file that is > 32 MiB but it definitely depends on filesystem layout (other files) and maybe some options (my EXTENT_DATA describe blocks of 1MiB size)? This also can happen to almost any file that is

Re: [U-Boot] [PATCH] fs: btrfs: Fix tree traversal with btrfs_next_slot()

2018-10-01 Thread Marek Behún
I shall test this today or tomorrow, but have too many things on my head, sorry :( You saying that this will fix reading large files? I haven't encountered such an error yet, but can try creating a large enough file. How large should it be? On Mon, 1 Oct 2018 08:50:11 +0300 Yevgeny Popovych wrot

Re: [U-Boot] [PATCH] fs: btrfs: Fix tree traversal with btrfs_next_slot()

2018-09-30 Thread Yevgeny Popovych
Just a kindly reminder :) On 09/07/2018 12:59 PM, Yevgeny Popovych wrote: > When traversing slots in a btree (via btrfs_path) with btrfs_next_slot(), > we didn't correctly identify that the last slot in the leaf was reached > and we should jump to the next leaf. > > This could lead to any kind of

[U-Boot] [PATCH] fs: btrfs: Fix tree traversal with btrfs_next_slot()

2018-09-07 Thread Yevgeny Popovych
When traversing slots in a btree (via btrfs_path) with btrfs_next_slot(), we didn't correctly identify that the last slot in the leaf was reached and we should jump to the next leaf. This could lead to any kind of runtime errors or corruptions, like: * file data not being read at all, or is read p