Re: [U-Boot] [PATCH] jffs2: some fixes to summary support

2009-08-24 Thread Wolfgang Denk
Dear Detlev Zundel, In message you wrote: > > Ok, if no more negative feedback comes in, I'm sure he'll apply this. I will not. Not again, that is :-) Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5

Re: [U-Boot] [PATCH] jffs2: some fixes to summary support

2009-08-24 Thread Detlev Zundel
Hi Scott, > On Fri, Aug 21, 2009 at 03:07:03PM +0200, Detlev Zundel wrote: >> Hi Scott, >> >> [...] >> >> > Nope. They do only some typecasting and resulting code still uses word >> > (halfword) access instructions. >> >> Can you take care of this patch? It seems to have fallen through the >>

Re: [U-Boot] [PATCH] jffs2: some fixes to summary support

2009-08-21 Thread Wolfgang Denk
Dear Ilya Yanok, In message <1247828562-9854-1-git-send-email-ya...@emcraft.com> you wrote: > This patch fixes some issues with JFFS2 summary support in U-Boot. > 1/ Summary support made compilation configurable (as summary support > considered expiremental even in Linux). > 2/ Summary code can do

Re: [U-Boot] [PATCH] jffs2: some fixes to summary support

2009-08-21 Thread Scott Wood
On Fri, Aug 21, 2009 at 03:07:03PM +0200, Detlev Zundel wrote: > Hi Scott, > > [...] > > > Nope. They do only some typecasting and resulting code still uses word > > (halfword) access instructions. > > Can you take care of this patch? It seems to have fallen through the > cracks somehow. I am

Re: [U-Boot] [PATCH] jffs2: some fixes to summary support

2009-08-21 Thread Detlev Zundel
Hi Scott, [...] > Nope. They do only some typecasting and resulting code still uses word > (halfword) access instructions. Can you take care of this patch? It seems to have fallen through the cracks somehow. Thanks! Detlev -- The success of PCs is in large part due to the fact that, by mak

Re: [U-Boot] [PATCH] jffs2: some fixes to summary support

2009-08-20 Thread Ilya Yanok
Hi Mike, Mike Frysinger wrote: >> +#ifdef CONFIG_JFFS2_SUMMARY >> +static u32 sum_get_unaligned32(u32 *ptr) >> +{ >> +u32 val; >> +u8 *p = (u8 *)ptr; >> + >> +val = *p | (*(p + 1) << 8) | (*(p + 2) << 16) | (*(p + 3) << 24); >> + >> +return __le32_to_cpu(val); >> +} >> + >> +static

Re: [U-Boot] [PATCH] jffs2: some fixes to summary support

2009-07-18 Thread Mike Frysinger
On Friday 17 July 2009 07:02:42 Ilya Yanok wrote: > +#ifdef CONFIG_JFFS2_SUMMARY > +static u32 sum_get_unaligned32(u32 *ptr) > +{ > + u32 val; > + u8 *p = (u8 *)ptr; > + > + val = *p | (*(p + 1) << 8) | (*(p + 2) << 16) | (*(p + 3) << 24); > + > + return __le32_to_cpu(val); > +} > +

[U-Boot] [PATCH] jffs2: some fixes to summary support

2009-07-17 Thread Ilya Yanok
This patch fixes some issues with JFFS2 summary support in U-Boot. 1/ Summary support made compilation configurable (as summary support considered expiremental even in Linux). 2/ Summary code can do unaligned 16-bit and 32-bit memory accesses. We need to get data byte by byte to exclude data aborts