Re: [U-Boot] [PATCH] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-04-29 Thread Eugeniu Rosca
Superseded by https://patchwork.ozlabs.org/patch/1092945/ ("[U-Boot,4/4] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y") -- Best Regards, Eugeniu. ___ U-Boot mailing list U-Boot@lists.denx.de https://lists.denx.de/listinfo/u-boot

Re: [U-Boot] [PATCH] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-04-29 Thread Eugeniu Rosca
Hi Lukasz, Thanks to Roman, we found a potential regression in this solution. Particularly when gen_rand_uuid() is called in a loop, get_timer(0) might return the same value, leading to the same seed value being passed to srand(), leading to the same uuid value being generated for several

Re: [U-Boot] [PATCH] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-04-29 Thread Eugeniu Rosca
Hi Lukasz, On Sat, Apr 27, 2019 at 05:05:28PM +0200, Lukasz Majewski wrote: [..] > Reviewed-by: Lukasz Majewski > Thank you for the prompt review. -- Best Regards, Eugeniu. ___ U-Boot mailing list U-Boot@lists.denx.de

Re: [U-Boot] [PATCH] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-04-27 Thread Lukasz Majewski
On Fri, 26 Apr 2019 23:54:58 +0200 Eugeniu Rosca wrote: > The random uuid values (enabled via CONFIG_RANDOM_UUID=y) on our > platform are always the same. Below is consistent on each cold boot: > > => ### reach U-Boot prompt > => setenv uuid_gpt_misc > => gpt verify mmc 1 $partitions >

[U-Boot] [PATCH] lib: uuid: Improve randomness of uuid values on RANDOM_UUID=y

2019-04-26 Thread Eugeniu Rosca
The random uuid values (enabled via CONFIG_RANDOM_UUID=y) on our platform are always the same. Below is consistent on each cold boot: => ### reach U-Boot prompt => setenv uuid_gpt_misc => gpt verify mmc 1 $partitions Verify GPT: success! => print uuid_gpt_misc