Re: [U-Boot] [PATCH] mcf: Fix cppcheck errors about uninitialized variables

On Fri, Nov 14, 2014 at 02:23:46PM +0100, Wolfgang Denk wrote: > Dear Albert, > > In message <20141114134733.01c82023@lilith> you wrote: > > > > > - u8 bootmode; > > > + u8 bootmode = 0; > > > > If you set bootmode to the default 0 value at declaration, then the code > > that follows in the sour

Re: [U-Boot] [PATCH] mcf: Fix cppcheck errors about uninitialized variables

Dear Albert, In message <20141114134733.01c82023@lilith> you wrote: > > > - u8 bootmode; > > + u8 bootmode = 0; > > If you set bootmode to the default 0 value at declaration, then the code > that follows in the source file can be simplified: > > u8 bootmode = 0; > ---8<--- > pcr

Re: [U-Boot] [PATCH] mcf: Fix cppcheck errors about uninitialized variables

Hello Alison, On Fri, 14 Nov 2014 14:56:12 +0800, Alison Wang wrote: > This patch will initialize the variables to fix the cppcheck errors as > follows. > > [arch/m68k/cpu/mcf5227x/speed.c:89]: (error) Uninitialized variable: bootmode > [arch/m68k/cpu/mcf532x/speed.c:248]: (error) Uninitialized

[U-Boot] [PATCH] mcf: Fix cppcheck errors about uninitialized variables

This patch will initialize the variables to fix the cppcheck errors as follows. [arch/m68k/cpu/mcf5227x/speed.c:89]: (error) Uninitialized variable: bootmode [arch/m68k/cpu/mcf532x/speed.c:248]: (error) Uninitialized variable: fout [arch/m68k/cpu/mcf5445x/speed.c:194]: (error) Uninitialized variab