Re: [U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-27 Thread Scott Wood
On 02/26/2013 09:04:22 PM, Harvey Chapman wrote: On Feb 26, 2013, at 8:42 PM, Scott Wood scottw...@freescale.com wrote: No need to be quite so verbose in the comments. If someone tries to change size to rwsize the compiler will complain about the type mismatch. Actually, it does give a

Re: [U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-26 Thread Scott Wood
On 02/25/2013 11:43:48 PM, Harvey Chapman wrote: Adjust the sizes calculated for whole partition/chip operations by removing the size of bad blocks so we don't try to erase/read/write past a partition/chip boundary. Signed-off-by: Harvey Chapman hchap...@3gfp.com --- common/cmd_nand.c | 51

Re: [U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-26 Thread Harvey Chapman
On Feb 26, 2013, at 8:42 PM, Scott Wood scottw...@freescale.com wrote: On 02/25/2013 11:43:48 PM, Harvey Chapman wrote: Looks OK except for style issues: Will do. +/* We grab the nand info object here fresh because this is usually + * called after arg_off_size() which can change

[U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-26 Thread Harvey Chapman
Adjust the sizes calculated for whole partition/chip operations by removing the size of bad blocks so we don't try to erase/read/write past a partition/chip boundary. Signed-off-by: Harvey Chapman hchap...@3gfp.com --- common/cmd_nand.c | 35 +++ 1 file changed,

[U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-25 Thread Harvey Chapman
Adjust the sizes calculated for whole partition/chip operations by removing the size of bad blocks so we don't try to erase/read/write past a partition/chip boundary. Signed-off-by: Harvey Chapman hchap...@3gfp.com --- common/cmd_nand.c | 51 +++

Re: [U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-25 Thread Harvey Chapman
[Slightly off-topic, but I can't find the answer with google] I changed the From: line in this patch e-mail to the address I use for this list rather than the address I committed with. Will this affect the author line once accepted upstream? That is, should I have left the From: address as it

Re: [U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-25 Thread Harvey Chapman
On Feb 26, 2013, at 12:22 AM, Harvey Chapman hchapman-ub...@3gfp.com wrote: [Slightly off-topic, but I can't find the answer with google] I changed the From: line in this patch e-mail to the address I use for this list rather than the address I committed with. Will this affect the author

[U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-25 Thread Harvey Chapman
From: Harvey Chapman hchap...@3gfp.com Adjust the sizes calculated for whole partition/chip operations by removing the size of bad blocks so we don't try to erase/read/write past a partition/chip boundary. Signed-off-by: Harvey Chapman hchap...@3gfp.com --- common/cmd_nand.c | 51

[U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-25 Thread Harvey Chapman
Adjust the sizes calculated for whole partition/chip operations by removing the size of bad blocks so we don't try to erase/read/write past a partition/chip boundary. Signed-off-by: Harvey Chapman hchap...@3gfp.com --- common/cmd_nand.c | 51 +++

Re: [U-Boot] [PATCH] nand: adjust erase/read/write partition/chip size for bad blocks

2013-02-25 Thread Harvey Chapman
Sorry for all of the e-mails while I fumble with git send-email. On Feb 26, 2013, at 12:43 AM, Harvey Chapman hchap...@3gfp.com wrote: Adjust the sizes calculated for whole partition/chip operations by removing the size of bad blocks so we don't try to erase/read/write past a partition/chip