Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

On Thursday 25 March 2010 15:11:10 Wolfgang Denk wrote: > Mike Frysinger wrote: > > > The question to me is why fec_probe() is called at all, even in cases > > > where U-Boot does not use any network related commands. This is IMO > > > wrong. Eventually somebody comes up with patches to fix this? >

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

Dear Mike Frysinger, In message <201003251338.18817.vap...@gentoo.org> you wrote: > > > The question to me is why fec_probe() is called at all, even in cases > > where U-Boot does not use any network related commands. This is IMO > > wrong. Eventually somebody comes up with patches to fix this? >

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

On Thursday 25 March 2010 09:16:55 Detlev Zundel wrote: > >> Ok, but this driver initialize in fec_probe() (which gets called > >> through fecmxc_initialize() on uboot startup) always the fec mac > >> address registers with eeprom mac address. So, if uboot not uses > > > > The question to me is wh

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

On Thursday 25 March 2010 05:40:01 Wolfgang Denk wrote: > Heiko wrote: > > Ok, but this driver initialize in fec_probe() (which gets called > > through fecmxc_initialize() on uboot startup) always the fec mac > > address registers with eeprom mac address. So, if uboot not uses > > The question to

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

Dear Detlev Zundel, In message you wrote: > > > The question to me is why fec_probe() is called at all, even in cases > > where U-Boot does not use any network related commands. This is IMO > > wrong. Eventually somebody comes up with patches to fix this? > > As I said before, this is documente

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

Hi Wolfgang, >> Ok, but this driver initialize in fec_probe() (which gets called >> through fecmxc_initialize() on uboot startup) always the fec mac >> address registers with eeprom mac address. So, if uboot not uses > > The question to me is why fec_probe() is called at all, even in cases > where

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

Dear Heiko, In message <4bab0357.60...@denx.de> you wrote: > > Ok, but this driver initialize in fec_probe() (which gets called > through fecmxc_initialize() on uboot startup) always the fec mac > address registers with eeprom mac address. So, if uboot not uses The question to me is why fec_prob

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

Hello Mike, Mike Frysinger wrote: > On Wednesday 24 March 2010 07:56:28 Heiko Schocher wrote: >> doc/README.enetaddr prescribes, to use a mac address stored in >> environment, before using a mac address stored in some special >> place. > > you're reading things incorrectly, or you didnt read the

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

On Wednesday 24 March 2010 08:52:26 Detlev Zundel wrote: > What Heiko _really_ fixes is that the board has a problem with linux > when no network transfer was done in U-Boot. Looking at the code, this > is quite obvious as this special driver does not program any mac address > into the controller

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

On Wednesday 24 March 2010 07:56:28 Heiko Schocher wrote: > doc/README.enetaddr prescribes, to use a mac address stored in > environment, before using a mac address stored in some special > place. you're reading things incorrectly, or you didnt read the whole thing. the fec_mxc driver is correct

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

Hello stefano, Stefano Babic wrote: > Heiko Schocher wrote: > > Hi Heiko, > >> Signed-off-by: Heiko Schocher >> --- >> drivers/net/fec_mxc.c | 15 +++ >> 1 files changed, 11 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c >> index 5a

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

Hi Stefano, > Heiko Schocher wrote: > > Hi Heiko, > >> >> Signed-off-by: Heiko Schocher >> --- >> drivers/net/fec_mxc.c | 15 +++ >> 1 files changed, 11 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c >> index 5af9cdb..b5245ec 100644

Re: [U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

Heiko Schocher wrote: Hi Heiko, > > Signed-off-by: Heiko Schocher > --- > drivers/net/fec_mxc.c | 15 +++ > 1 files changed, 11 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/fec_mxc.c b/drivers/net/fec_mxc.c > index 5af9cdb..b5245ec 100644 > --- a/drivers/net/fec_mx

[U-Boot] [PATCH] net, fec_mxc: use mac address stored in env before looking in eeprom

doc/README.enetaddr prescribes, to use a mac address stored in environment, before using a mac address stored in some special place. This patch fixes this for the fec_mxc driver. Tested on the magnesium board. Signed-off-by: Heiko Schocher --- drivers/net/fec_mxc.c | 15 +++ 1 fil