Re: [U-Boot] [PATCH] net/eth.c: bug-fix

2010-03-23 Thread Ben Warren
Hi Wolfgang, On 3/23/2010 12:52 PM, Wolfgang Denk wrote: > Dear Ben Warren, > > In message<4ba8f738.3050...@gmail.com> you wrote: > >>> Do you have this patch in your queue? >>> >>> >> No, I don't. This patch is wrong, and I believe I already responded >> about it

Re: [U-Boot] [PATCH] net/eth.c: bug-fix

2010-03-23 Thread Wolfgang Denk
Dear Ben Warren, In message <4ba8f738.3050...@gmail.com> you wrote: > >> > > Do you have this patch in your queue? > > > No, I don't. This patch is wrong, and I believe I already responded > about it. The code does need a subtle clean-up, but I haven't quite > found the time to do it

Re: [U-Boot] [PATCH] net/eth.c: bug-fix

2010-03-23 Thread Ben Warren
Wolfgang, On 3/21/2010 1:38 PM, Wolfgang Denk wrote: > Dear Ben, > > In message<3270dcac1b1540c7b13d9bc718f54...@smartbridges.com> Teh Kok How > wrote: > >> Fixes: Board_eth_init() calls pci_eth_init() (include/netdev.h) and if >> ethernet is soc, CONFIG_PCI is not defined, pci_eth_init() ret

Re: [U-Boot] [PATCH] net/eth.c: bug-fix

2010-03-21 Thread Wolfgang Denk
Dear Ben, In message <3270dcac1b1540c7b13d9bc718f54...@smartbridges.com> Teh Kok How wrote: > Fixes: Board_eth_init() calls pci_eth_init() (include/netdev.h) and if > ethernet is soc, CONFIG_PCI is not defined, pci_eth_init() returns 0. > This patch allows cpu_eth_init() to be called. > > > Sig

Re: [U-Boot] [PATCH] net/eth.c: bug-fix

2010-02-12 Thread Ben Warren
Hello Teh Kok How, On Thu, Feb 11, 2010 at 10:57 PM, Teh Kok How wrote: > No, it is a bug. Board_eth_init() calls pci_eth_init() (include/netdev.h) > and if ethernet is soc, CONFIG_PCI is not defined, pci_eth_init() returns > 0. > This patch allows cpu_eth_init() to be called. > > Sorry, still no

Re: [U-Boot] [PATCH] net/eth.c: bug-fix

2010-02-12 Thread Teh Kok How
Fixes: Board_eth_init() calls pci_eth_init() (include/netdev.h) and if ethernet is soc, CONFIG_PCI is not defined, pci_eth_init() returns 0. This patch allows cpu_eth_init() to be called. Signed-off-by: Kok How, Teh --- u-boot-2009.11.1.orig/net/eth.c 2010-01-25 16:35:12.0 +0800 +++

Re: [U-Boot] [PATCH] net/eth.c: bug-fix

2010-02-11 Thread Teh Kok How
, February 12, 2010 1:54 PM To: Teh Kok How Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH] net/eth.c: bug-fix On 2/11/2010 8:08 PM, Teh Kok How wrote: > --- u-boot-2009.11.1.orig/net/eth.c 2010-01-25 16:35:12.0 +0800 > > +++ u-boot-2009.11.1/net/eth.c 2010-02-12 11:18:23.

Re: [U-Boot] [PATCH] net/eth.c: bug-fix

2010-02-11 Thread Ben Warren
On 2/11/2010 8:08 PM, Teh Kok How wrote: > --- u-boot-2009.11.1.orig/net/eth.c 2010-01-25 16:35:12.0 +0800 > > +++ u-boot-2009.11.1/net/eth.c 2010-02-12 11:18:23.558229895 +0800 > > @@ -199,7 +199,7 @@ > > #endif > > /* Try board-specific initialization first. If it fails o

[U-Boot] [PATCH] net/eth.c: bug-fix

2010-02-11 Thread Teh Kok How
--- u-boot-2009.11.1.orig/net/eth.c 2010-01-25 16:35:12.0 +0800 +++ u-boot-2009.11.1/net/eth.c 2010-02-12 11:18:23.558229895 +0800 @@ -199,7 +199,7 @@ #endif /* Try board-specific initialization first. If it fails or isn't * present, try the cpu-specific initial